Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2131913003: Revert of Refactor NACK bitrate allocation (Closed)

Created:
4 years, 5 months ago by sprang_webrtc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), the sun, zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, hlundin-webrtc, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactor NACK bitrate allocation (patchset #16 id:300001 of https://codereview.webrtc.org/2061423003/ ) Reason for revert: Breaks upstream code. Original issue's description: > Refactor NACK bitrate allocation > > Nack bitrate allocation should not be done on a per-rtp-module basis, > but rather shared bitrate pool per call. This CL moves allocation to the > pacer and cleans up a bunch if bitrate stats handling. > > BUG= > R=danilchap@webrtc.org, stefan@webrtc.org, tommi@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/5fc59e810b8ea848702f2dbc740fe190608e1413 TBR=tommi@webrtc.org,danilchap@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e5dd44101eca485f5ad12e5f7ce6f6b0d204116b Cr-Commit-Position: refs/heads/master@{#13417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+625 lines, -608 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/base/rate_limiter.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/base/rate_limiter.cc View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/base/rate_limiter_unittest.cc View 1 chunk +0 lines, -205 lines 0 comments Download
M webrtc/base/rate_statistics.h View 1 chunk +4 lines, -19 lines 0 comments Download
M webrtc/base/rate_statistics.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/call/rtc_event_log_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/common_types.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 7 chunks +1 line, -22 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 3 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/bitrate.h View 1 chunk +77 lines, -0 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/bitrate.cc View 1 chunk +121 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 5 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 5 chunks +10 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 7 chunks +31 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 5 chunks +1 line, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 10 chunks +55 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 18 chunks +163 lines, -50 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 17 chunks +32 lines, -43 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 6 chunks +12 lines, -14 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 8 chunks +9 lines, -42 lines 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/payload_router.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 4 chunks +18 lines, -17 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 4 chunks +1 line, -3 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sprang_webrtc
Created Revert of Refactor NACK bitrate allocation
4 years, 5 months ago (2016-07-08 16:38:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2131913003/1
4 years, 5 months ago (2016-07-08 16:38:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 16:38:58 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e5dd44101eca485f5ad12e5f7ce6f6b0d204116b Cr-Commit-Position: refs/heads/master@{#13417}
4 years, 5 months ago (2016-07-08 16:39:06 UTC) #6
sprang_webrtc
4 years, 5 months ago (2016-07-13 15:36:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2146013002/ by sprang@webrtc.org.

The reason for reverting is: Upstream fixes in place, should be OK now..

Powered by Google App Engine
This is Rietveld 408576698