Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2131313002: Reland Issue 2061423003: Refactor NACK bitrate allocation (Closed)

Created:
4 years, 5 months ago by sprang_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland Issue 2061423003: Refactor NACK bitrate allocation This is a reland of https://codereview.webrtc.org/2061423003/ Which was reverted in https://codereview.webrtc.org/2131913003/ The reason for the revert was that some upstream code used RtpSender::SetTargetBitrate(). I've added that back as a no-op until we it's been brought up to date. TBR=tommi@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/05ce4ae31f635c16e10b68601e7e07fdf7bbb29b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -616 lines) Patch
M webrtc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/base.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/base/rate_limiter.h View 1 chunk +56 lines, -0 lines 0 comments Download
A webrtc/base/rate_limiter.cc View 1 chunk +65 lines, -0 lines 0 comments Download
A webrtc/base/rate_limiter_unittest.cc View 1 chunk +205 lines, -0 lines 0 comments Download
M webrtc/base/rate_statistics.h View 1 chunk +19 lines, -4 lines 0 comments Download
M webrtc/base/rate_statistics.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/call/rtc_event_log_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/common_types.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 7 chunks +22 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 3 chunks +3 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/rtp_rtcp.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/bitrate.h View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/modules/rtp_rtcp/source/bitrate.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 5 chunks +7 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 5 chunks +4 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 7 chunks +5 lines, -31 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_video.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc View 5 chunks +7 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 10 chunks +8 lines, -54 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 19 chunks +48 lines, -157 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 17 chunks +42 lines, -31 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 6 chunks +14 lines, -12 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 8 chunks +41 lines, -8 lines 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/video/payload_router.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M webrtc/video/rtp_stream_receiver.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 4 chunks +17 lines, -18 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 4 chunks +3 lines, -1 line 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2131313002/1
4 years, 5 months ago (2016-07-08 16:53:23 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/05ce4ae31f635c16e10b68601e7e07fdf7bbb29b Cr-Commit-Position: refs/heads/master@{#13418}
4 years, 5 months ago (2016-07-08 17:11:33 UTC) #5
sprang_webrtc
Committed patchset #1 (id:1) manually as 05ce4ae31f635c16e10b68601e7e07fdf7bbb29b (presubmit successful).
4 years, 5 months ago (2016-07-08 17:11:33 UTC) #6
aluebs-webrtc
4 years, 5 months ago (2016-07-08 18:01:25 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2130423002/ by aluebs@webrtc.org.

The reason for reverting is: It keeps breaking upstream..

Powered by Google App Engine
This is Rietveld 408576698