Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2129663002: Remove unused NonlinearBeamformer interface (Closed)

Created:
4 years, 5 months ago by aluebs-webrtc
Modified:
4 years, 5 months ago
Reviewers:
turaj
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused NonlinearBeamformer interface Committed: https://crrev.com/95663fe7464c2c022cbbf83fa3a7b7b8932be999 Cr-Commit-Position: refs/heads/master@{#13451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
aluebs-webrtc
4 years, 5 months ago (2016-07-06 17:50:57 UTC) #2
turaj
lgtm
4 years, 5 months ago (2016-07-12 18:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2129663002/1
4 years, 5 months ago (2016-07-12 18:59:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 19:43:05 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 19:43:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/95663fe7464c2c022cbbf83fa3a7b7b8932be999
Cr-Commit-Position: refs/heads/master@{#13451}

Powered by Google App Engine
This is Rietveld 408576698