Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2129603003: Add a fuzzer for the pseudoTCP implementation used by chromoting. This (Closed)

Created:
4 years, 5 months ago by katrielc1
Modified:
4 years, 5 months ago
Reviewers:
phoglund, katrielc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a fuzzer for the pseudoTCP implementation used by chromoting. This found chromium:620694. Unfortunately it depends on unsafe GN targets, so do not build in Chromium. NOTRY=true Committed: https://crrev.com/44905cf49f53709cb4d0b9bdb62871d2988dbf0d Cr-Commit-Position: refs/heads/master@{#13407}

Patch Set 1 #

Patch Set 2 : Use a global PseudoTcp object for efficiency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
A webrtc/test/fuzzers/pseudotcp_parser_fuzzer.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
katrielc
Another one!
4 years, 5 months ago (2016-07-07 11:18:03 UTC) #2
phoglund
lgtm
4 years, 5 months ago (2016-07-07 12:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2129603003/20001
4 years, 5 months ago (2016-07-07 12:47:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-07 12:52:28 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 12:52:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44905cf49f53709cb4d0b9bdb62871d2988dbf0d
Cr-Commit-Position: refs/heads/master@{#13407}

Powered by Google App Engine
This is Rietveld 408576698