Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 2128583003: Remove unused CriticalSection::IsLocked() (Closed)

Created:
4 years, 5 months ago by andresp
Modified:
4 years, 5 months ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused CriticalSection::IsLocked() Committed: https://crrev.com/388d8e92b89951f49604ac6d810aca08a820d84b Cr-Commit-Position: refs/heads/master@{#13409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M webrtc/base/criticalsection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/base/criticalsection_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
andresp
4 years, 5 months ago (2016-07-06 18:10:00 UTC) #2
andresp
Tommi, can you review this? It is removing methods that were used only in tests.
4 years, 5 months ago (2016-07-07 12:54:32 UTC) #4
tommi
lgtm
4 years, 5 months ago (2016-07-07 15:20:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2128583003/1
4 years, 5 months ago (2016-07-08 07:10:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 08:19:40 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 08:19:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/388d8e92b89951f49604ac6d810aca08a820d84b
Cr-Commit-Position: refs/heads/master@{#13409}

Powered by Google App Engine
This is Rietveld 408576698