Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: webrtc/modules/audio_mixer/include/audio_mixer_defines.h

Issue 2127763002: Removed the memory pool from the mixer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@removed_time_scheduler
Patch Set: Changes from reviewer comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_
12 #define WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_ 12 #define WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_
13 13
14 #include "webrtc/base/checks.h" 14 #include "webrtc/base/checks.h"
15 #include "webrtc/modules/include/module_common_types.h" 15 #include "webrtc/modules/include/module_common_types.h"
16 #include "webrtc/typedefs.h" 16 #include "webrtc/typedefs.h"
17 17
18 namespace webrtc { 18 namespace webrtc {
19 class NewMixHistory; 19 class NewMixHistory;
20 20
21 // A callback class that all mixer participants must inherit from/implement. 21 // A callback class that all mixer participants must inherit from/implement.
22 class MixerAudioSource { 22 class MixerAudioSource {
23 public: 23 public:
24 // The implementation of this function should update audioFrame with new
25 // audio every time it's called.
26 //
27 // If it returns -1, the frame will not be added to the mix.
28 //
29 // NOTE: This function should not be called. It will remain for a short
30 // time so that subclasses can override it without getting warnings.
31 // TODO(henrik.lundin) Remove this function.
32 virtual int32_t GetAudioFrame(int32_t id, AudioFrame* audioFrame) {
33 RTC_CHECK(false);
34 return -1;
35 }
36 24
37 // The implementation of GetAudioFrameWithMuted should update audio_frame
38 // with new audio every time it's called. The return value will be
39 // interpreted as follows.
40 enum class AudioFrameInfo { 25 enum class AudioFrameInfo {
41 kNormal, // The samples in audio_frame are valid and should be used. 26 kNormal, // The samples in audio_frame are valid and should be used.
42 kMuted, // The samples in audio_frame should not be used, but should be 27 kMuted, // The samples in audio_frame should not be used, but should be
43 // implicitly interpreted as zero. Other fields in audio_frame 28 // implicitly interpreted as zero. Other fields in audio_frame
44 // may be read and should contain meaningful values. 29 // may be read and should contain meaningful values.
45 kError // audio_frame will not be used. 30 kError // audio_frame will not be used.
46 }; 31 };
47 32
48 virtual AudioFrameInfo GetAudioFrameWithMuted(int32_t id, 33 struct AudioFrameWithInfo {
49 AudioFrame* audio_frame) { 34 AudioFrame* audio_frame_pointer;
ossu 2016/07/06 12:58:44 I think this should just be called audio_frame (wi
50 return GetAudioFrame(id, audio_frame) == -1 ? AudioFrameInfo::kError 35 AudioFrameInfo audio_frame_info;
51 : AudioFrameInfo::kNormal; 36 };
52 } 37
38 // The implementation of GetAudioFrameWithMuted should update
39 // audio_frame with new audio every time it's called. Implementing
40 // classes are allowed to return the same AudioFrame pointer on
41 // different calls.
42 virtual AudioFrameWithInfo GetAudioFrameWithMuted(int32_t id,
43 int sample_rate_hz) = 0;
53 44
54 // Returns true if the participant was mixed this mix iteration. 45 // Returns true if the participant was mixed this mix iteration.
55 bool IsMixed() const; 46 bool IsMixed() const;
56 47
57 // This function specifies the sampling frequency needed for the AudioFrame 48 // This function specifies the sampling frequency needed for the AudioFrame
58 // for future GetAudioFrame(..) calls. 49 // for future GetAudioFrame(..) calls.
59 virtual int32_t NeededFrequency(int32_t id) const = 0; 50 virtual int32_t NeededFrequency(int32_t id) const = 0;
60 51
61 NewMixHistory* _mixHistory; 52 NewMixHistory* _mixHistory;
62 53
63 protected: 54 protected:
64 MixerAudioSource(); 55 MixerAudioSource();
65 virtual ~MixerAudioSource(); 56 virtual ~MixerAudioSource();
66 }; 57 };
67 } // namespace webrtc 58 } // namespace webrtc
68 59
69 #endif // WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_ 60 #endif // WEBRTC_MODULES_AUDIO_MIXER_INCLUDE_AUDIO_MIXER_DEFINES_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698