Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2127073002: Bugfix for Vp9 GOF and missing frames. (Closed)

Created:
4 years, 5 months ago by philipel
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Bugfix for Vp9 GOF and missing frames. In order to correctly determine the references of a frame when using Vp9 with GOF one has to wait for all frames on the lower temporal layers to make sure no up-switch point is missed. This patch fix a bug where upon receiving a frame the RtpFrameReferenceFinder would try to add missing frame for a group with a not yet knows scalability structure. BUG=webrtc:5514 Committed: https://crrev.com/c9b27d56c0b97a82ea3ed6075d8d6463e408f0d9 Cr-Commit-Position: refs/heads/master@{#13487}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Better unittest describing the bug fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -51 lines) Patch
M webrtc/modules/video_coding/rtp_frame_reference_finder.h View 3 chunks +15 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/rtp_frame_reference_finder.cc View 1 6 chunks +40 lines, -43 lines 0 comments Download
M webrtc/modules/video_coding/video_packet_buffer_unittest.cc View 1 2 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipel
4 years, 5 months ago (2016-07-07 09:08:53 UTC) #2
philipel
ping
4 years, 5 months ago (2016-07-15 10:35:05 UTC) #3
stefan-webrtc
lgtm
4 years, 5 months ago (2016-07-15 12:20:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2127073002/40001
4 years, 5 months ago (2016-07-15 12:43:40 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 13:50:31 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 13:50:44 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9b27d56c0b97a82ea3ed6075d8d6463e408f0d9
Cr-Commit-Position: refs/heads/master@{#13487}

Powered by Google App Engine
This is Rietveld 408576698