webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc - Issue 2126793002: Reset InterArrival if arrival time clock makes a jump.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc

Issue 2126793002: Reset InterArrival if arrival time clock makes a jump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/remote_bitrate_estimator/inter_arrival.cc ('K') | « webrtc/modules/remote_bitrate_estimator/inter_arrival.cc ('k') | webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc » ('j') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc b/webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc

index 3b4151b3b7948eaf9facb8fa1274b76b72ae4772..e1feb66ac5984dacd6003c316383369848ba1fa3 100644

--- a/webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc

+++ b/webrtc/modules/remote_bitrate_estimator/inter_arrival_unittest.cc

@@ -166,12 +166,9 @@ class InterArrivalTest : public ::testing::Test {

uint32_t dummy_timestamp = 101;

int64_t dummy_arrival_time_ms = 303;

int dummy_packet_size = 909;

- bool computed = inter_arrival->ComputeDeltas(timestamp,

- arrival_time_ms,

- packet_size,

- &dummy_timestamp,

- &dummy_arrival_time_ms,

- &dummy_packet_size);

+ bool computed = inter_arrival->ComputeDeltas(

+ timestamp, arrival_time_ms, arrival_time_ms, packet_size,

+ &dummy_timestamp, &dummy_arrival_time_ms, &dummy_packet_size);

EXPECT_EQ(computed, false);

EXPECT_EQ(101ul, dummy_timestamp);

EXPECT_EQ(303, dummy_arrival_time_ms);

@@ -188,12 +185,9 @@ class InterArrivalTest : public ::testing::Test {

uint32_t delta_timestamp = 101;

int64_t delta_arrival_time_ms = 303;

int delta_packet_size = 909;

- bool computed = inter_arrival->ComputeDeltas(timestamp,

- arrival_time_ms,

- packet_size,

- &delta_timestamp,

- &delta_arrival_time_ms,

- &delta_packet_size);

+ bool computed = inter_arrival->ComputeDeltas(

+ timestamp, arrival_time_ms, arrival_time_ms, packet_size,

+ &delta_timestamp, &delta_arrival_time_ms, &delta_packet_size);

EXPECT_EQ(true, computed);

EXPECT_NEAR(expected_timestamp_delta, delta_timestamp, timestamp_near);

EXPECT_EQ(expected_arrival_time_delta_ms, delta_arrival_time_ms);