Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2125523004: Fix bug where a connection switch causes BWE to be set to zero. (Closed)

Created:
4 years, 5 months ago by stefan-webrtc
Modified:
4 years, 5 months ago
Reviewers:
terelius, sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix bug where a connection switch causes BWE to be set to zero. BUG=webrtc:6076 R=sprang@webrtc.org Committed: https://crrev.com/be40296ccef50dd79312c6fce533bfa36b7063dc Cr-Commit-Position: refs/heads/master@{#13414}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved fix to call.cc and added a better test. #

Total comments: 4

Patch Set 3 : Comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M webrtc/call/call.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
stefan-webrtc
4 years, 5 months ago (2016-07-05 11:52:13 UTC) #2
terelius
https://codereview.webrtc.org/2125523004/diff/1/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc File webrtc/modules/bitrate_controller/bitrate_controller_impl.cc (right): https://codereview.webrtc.org/2125523004/diff/1/webrtc/modules/bitrate_controller/bitrate_controller_impl.cc#newcode151 webrtc/modules/bitrate_controller/bitrate_controller_impl.cc:151: if (bitrate_bps == -1) { If -1 has a ...
4 years, 5 months ago (2016-07-05 13:55:36 UTC) #3
stefan-webrtc
I have improved the fix and also added a test which verifies the actual issue ...
4 years, 5 months ago (2016-07-07 11:50:46 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2125523004/20001
4 years, 5 months ago (2016-07-07 11:52:08 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-07 13:25:07 UTC) #8
terelius
https://codereview.webrtc.org/2125523004/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2125523004/diff/20001/webrtc/call/call.cc#newcode584 webrtc/call/call.cc:584: // no point in remembering for the future. I ...
4 years, 5 months ago (2016-07-07 15:48:38 UTC) #9
terelius
https://codereview.webrtc.org/2125523004/diff/20001/webrtc/call/call.cc File webrtc/call/call.cc (right): https://codereview.webrtc.org/2125523004/diff/20001/webrtc/call/call.cc#newcode584 webrtc/call/call.cc:584: // no point in remembering for the future. On ...
4 years, 5 months ago (2016-07-08 08:42:36 UTC) #10
stefan-webrtc
Comments addressed.
4 years, 5 months ago (2016-07-08 10:21:53 UTC) #11
stefan-webrtc
https://codereview.webrtc.org/2125523004/diff/20001/webrtc/video/video_send_stream_tests.cc File webrtc/video/video_send_stream_tests.cc (right): https://codereview.webrtc.org/2125523004/diff/20001/webrtc/video/video_send_stream_tests.cc#newcode1145 webrtc/video/video_send_stream_tests.cc:1145: call_->GetStats().send_bandwidth_bps > kStartBitrateBps) { On 2016/07/07 15:48:38, terelius wrote: ...
4 years, 5 months ago (2016-07-08 10:21:59 UTC) #12
sprang_webrtc
lgtm
4 years, 5 months ago (2016-07-08 13:21:22 UTC) #14
stefan-webrtc
terelius: I will submit this as is, but if you have any more comments I'll ...
4 years, 5 months ago (2016-07-08 13:23:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2125523004/40001
4 years, 5 months ago (2016-07-08 13:23:20 UTC) #17
stefan-webrtc
Committed patchset #3 (id:40001) manually as be40296ccef50dd79312c6fce533bfa36b7063dc (presubmit successful).
4 years, 5 months ago (2016-07-08 14:16:58 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/be40296ccef50dd79312c6fce533bfa36b7063dc Cr-Commit-Position: refs/heads/master@{#13414}
4 years, 5 months ago (2016-07-08 14:16:58 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_rel on master.tryserver.webrtc (JOB_FAILED, no build URL)
4 years, 5 months ago (2016-07-08 14:30:11 UTC) #23
terelius
4 years, 5 months ago (2016-07-12 19:21:31 UTC) #24
lgtm

Powered by Google App Engine
This is Rietveld 408576698