Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2125283002: Reland of ll chromium_revision 54c8d0a5e2..39c812dd97 (403836:404030) (Closed)

Created:
4 years, 5 months ago by stefan-webrtc
Modified:
4 years, 5 months ago
Reviewers:
buildbot
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of ll chromium_revision 54c8d0a5e2..39c812dd97 (403836:404030) (patchset #1 id:1 of https://codereview.webrtc.org/2123323003/ ) Reason for revert: Didn't solve the upstream breakage. Original issue's description: > Revert of Roll chromium_revision 54c8d0a5e2..39c812dd97 (403836:404030) (patchset #1 id:1 of https://codereview.webrtc.org/2123373003/ ) > > Reason for revert: > Might have broken upstream projects. Will reland if not. > > Original issue's description: > > Roll chromium_revision 54c8d0a5e2..39c812dd97 (403836:404030) > > > > Change log: https://chromium.googlesource.com/chromium/src/+log/54c8d0a5e2..39c812dd97 > > Full diff: https://chromium.googlesource.com/chromium/src/+/54c8d0a5e2..39c812dd97 > > > > Changed dependencies: > > * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/d2664782a3..aa47d9773d > > * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/c61b0b35c8..bac4680ec9 > > DEPS diff: https://chromium.googlesource.com/chromium/src/+/54c8d0a5e2..39c812dd97/DEPS > > > > No update to Clang. > > > > TBR= > > > > Committed: https://crrev.com/e7e6a07f7301b0262025113a4e08eba4cb338ad8 > > Cr-Commit-Position: refs/heads/master@{#13401} > > TBR=buildbot@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/cf47f0bd637690ee7170ef5dbf3765a858eb1c52 > Cr-Commit-Position: refs/heads/master@{#13405} TBR=buildbot@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b17bfa996d52209b498e9d57b5ec1c2709db9b53 Cr-Commit-Position: refs/heads/master@{#13406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
stefan-webrtc
Created Reland of ll chromium_revision 54c8d0a5e2..39c812dd97 (403836:404030)
4 years, 5 months ago (2016-07-07 12:32:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2125283002/1
4 years, 5 months ago (2016-07-07 12:32:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 12:32:57 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 12:33:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b17bfa996d52209b498e9d57b5ec1c2709db9b53
Cr-Commit-Position: refs/heads/master@{#13406}

Powered by Google App Engine
This is Rietveld 408576698