Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2125183002: Change GetPlayoutTimestamp message from Error to Info (Closed)

Created:
4 years, 5 months ago by skvlad
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change GetPlayoutTimestamp message from Error to Info This message was printed to the receiver's log on every single video frame if the remote side is sending video but not audio. This could happen if, for example, one participant creates RtpSenders for both audio and video but doesn't set the audio track, or if the track is set but RtpParameters.encodings[0].active == false. This CL changes the trace level to StateInfo as it is the expected behavior in this case. R=deadbeef@webrtc.org, henrika@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/4c0536bd510a17c0d793ff3f811c25bee7f60fea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/voice_engine/channel.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
skvlad
4 years, 5 months ago (2016-07-06 21:19:04 UTC) #3
skvlad
+deadbeef@
4 years, 5 months ago (2016-07-07 02:07:35 UTC) #5
henrika_webrtc
LGTM
4 years, 5 months ago (2016-07-07 07:55:40 UTC) #6
Taylor Brandstetter
lgtm
4 years, 5 months ago (2016-07-07 15:50:22 UTC) #7
Taylor Brandstetter
lgtm
4 years, 5 months ago (2016-07-07 15:50:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2125183002/1
4 years, 5 months ago (2016-07-07 18:05:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-07 20:05:44 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c0536bd510a17c0d793ff3f811c25bee7f60fea Cr-Commit-Position: refs/heads/master@{#13408}
4 years, 5 months ago (2016-07-07 20:06:43 UTC) #14
skvlad
4 years, 5 months ago (2016-07-07 20:06:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c0536bd510a17c0d793ff3f811c25bee7f60fea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698