Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 2124983002: Android SurfaceViewRenderer: Fix eglBase null pointer exception (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 5 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android SurfaceViewRenderer: Fix eglBase null pointer exception Add null checks for eglBase, and detach the egl context in SurfaceViewRenderer.surfaceDestroyed(). BUG=webrtc:6032 R=sakal@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/44abcb5e41c463f0b6f1c415a91052fe14058995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
magjed_webrtc
sami - Please take a look.
4 years, 5 months ago (2016-07-06 11:19:20 UTC) #3
sakal
lgtm
4 years, 5 months ago (2016-07-06 12:01:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2124983002/1
4 years, 5 months ago (2016-07-06 12:05:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-06 14:06:38 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/44abcb5e41c463f0b6f1c415a91052fe14058995 Cr-Commit-Position: refs/heads/master@{#13396}
4 years, 5 months ago (2016-07-06 14:16:28 UTC) #11
magjed_webrtc
4 years, 5 months ago (2016-07-06 14:16:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44abcb5e41c463f0b6f1c415a91052fe14058995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698