Added various timestamps to FrameObject.

webrtc/modules/video_coding/frame_object.h

Index: webrtc/modules/video_coding/frame_object.h
diff --git a/webrtc/modules/video_coding/frame_object.h b/webrtc/modules/video_coding/frame_object.h
index b0d0d12e024fa88c21a5f6135ccd8c4c9bd5a18f..592ac2661f02a5bfd36d4294d15f90c6f5497b5e 100644
--- a/webrtc/modules/video_coding/frame_object.h
+++ b/webrtc/modules/video_coding/frame_object.h
@@ -25,6 +25,9 @@ class FrameObject : public webrtc::VCMEncodedFrame {
   FrameObject();
 
   virtual bool GetBitstream(uint8_t* destination) const = 0;
+  virtual uint32_t Timestamp() const = 0;

[terelius, 2016/07/07 16:12:30]

Which timestamp is this? From the RTP header? Please add a comment.

[philipel, 2016/07/08 09:41:19]

Done.

+  virtual int64_t ReceivedTimestamp() const = 0;
+  virtual int64_t RenderTimestamp() const = 0;

[stefan-webrtc, 2016/07/08 10:33:39]

I'd prefer if we don't overuse the word timestamp as it is tightly connected to
the RTP timestamp. Can we instead use RenderTime and ReceivedTime()? Maybe
ReceivedTime should be called CompleteTime instead?

[philipel, 2016/07/08 11:10:50]

Done.

   virtual ~FrameObject() {}
 
   // The tuple (|picture_id|, |spatial_layer|) uniquely identifies a frame
@@ -49,7 +52,8 @@ class RtpFrameObject : public FrameObject {
                  uint16_t first_seq_num,
                  uint16_t last_seq_num,
                  size_t frame_size,
-                 int times_nacked);
+                 int times_nacked,
+                 int64_t frame_completed_timestamp);

[terelius, 2016/07/07 16:12:30]

Different name in the implementation.

[philipel, 2016/07/08 09:41:19]

Fixed.

 
   ~RtpFrameObject();
   uint16_t first_seq_num() const;
@@ -58,6 +62,9 @@ class RtpFrameObject : public FrameObject {
   enum FrameType frame_type() const;
   VideoCodecType codec_type() const;
   bool GetBitstream(uint8_t* destination) const override;
+  uint32_t Timestamp() const override;
+  int64_t ReceivedTimestamp() const override;
+  int64_t RenderTimestamp() const override;
   RTPVideoTypeHeader* GetCodecHeader() const;
 
  private:
@@ -66,6 +73,8 @@ class RtpFrameObject : public FrameObject {
   VideoCodecType codec_type_;
   uint16_t first_seq_num_;
   uint16_t last_seq_num_;
+  uint32_t timestamp_;
+  int64_t received_timestamp_;
 
   // Equal to times nacked of the packet with the highet times nacked
   // belonging to this frame.