Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: webrtc/modules/audio_coding/codecs/audio_format.h

Issue 2123923004: Updated AudioDecoderFactory to list AudioCodecSpecs instead of SdpAudioFormats. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@audio-decoder-factory-usage
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/audio_format.h
diff --git a/webrtc/modules/audio_coding/codecs/audio_format.h b/webrtc/modules/audio_coding/codecs/audio_format.h
index 09075e49acba9b378af2aa47bc993cd9fc9181a2..6a9f315bdf7144e633d244aab751cd3e3fdc2cc9 100644
--- a/webrtc/modules/audio_coding/codecs/audio_format.h
+++ b/webrtc/modules/audio_coding/codecs/audio_format.h
@@ -43,12 +43,17 @@ struct SdpAudioFormat {
int clockrate_hz;
int num_channels;
Parameters parameters;
- // Parameters feedback_parameters; ??
};
void swap(SdpAudioFormat& a, SdpAudioFormat& b);
std::ostream& operator<<(std::ostream& os, const SdpAudioFormat& saf);
+struct AudioCodecSpec {
+ SdpAudioFormat format;
+ bool allow_comfort_noise; // This encoder can be used with an external
ivoc 2016/07/08 13:06:07 How about just putting this in the SdpAudioFormat
ossu 2016/07/08 13:17:12 No, because it doesn't make sense in SdpAudioForma
ivoc 2016/07/08 13:37:34 Acknowledged.
+ // comfort noise generator.
+};
+
} // namespace webrtc
#endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_AUDIO_FORMAT_H_

Powered by Google App Engine
This is Rietveld 408576698