Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2123773002: Changes in UI and minor extra functionality for rtp_analyzer. (Closed)

Created:
4 years, 5 months ago by aleloi
Modified:
4 years, 5 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changes in UI and minor extra functionality for rtp_analyzer. 1. The tool now displays packet loss in %. 2. It can print header information to stdout like rtp_analyze. 3. It has a command-line switch that lets you override the sample rate guessing. With the flag "--query_sample_rate" the tool asks you to always provide a sample rate. 4. Less decimals are printed for the estimated sample rate. NOTRY=True Committed: https://crrev.com/0e7000b20a5a3f7a420dfe1ef4fa7f3347cded75 Cr-Commit-Position: refs/heads/master@{#13385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M webrtc/tools/py_event_log_analyzer/README View 1 chunk +7 lines, -1 line 0 comments Download
M webrtc/tools/py_event_log_analyzer/pb_parse.py View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/py_event_log_analyzer/rtp_analyzer.py View 6 chunks +44 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
aleloi
This CL contains some minor UI changes and new functionality for the python tool rtp_analyzer. ...
4 years, 5 months ago (2016-07-05 12:52:28 UTC) #4
phoglund
lgtm
4 years, 5 months ago (2016-07-05 14:29:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2123773002/1
4 years, 5 months ago (2016-07-05 14:51:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 14:53:40 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 14:53:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e7000b20a5a3f7a420dfe1ef4fa7f3347cded75
Cr-Commit-Position: refs/heads/master@{#13385}

Powered by Google App Engine
This is Rietveld 408576698