Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2123203002: Merge to 53 branch: Fix bug where min transmit bitrate wasn't working (Closed)

Created:
4 years, 5 months ago by sprang_webrtc
Modified:
4 years, 5 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@53
Target Ref:
refs/pending/branch-heads/53
Project:
webrtc
Visibility:
Public.

Description

Merge to 53 branch: Fix bug where min transmit bitrate wasn't working A recent refactoring (r13192) introduced a bug where the min transmit config wasn't being respected. Specifically, if a VideoSendStream was created without it and the reconfigured, the min transmit bitrate would not take effect. Probably the other way around as well. TBR=tommi@webrtc.org BUG=webrtc:5687, webrtc:6080, 627017 patch from issue 2106183002 (http://crrev.com/2106183002) Committed: https://chromium.googlesource.com/external/webrtc/+/fdc2e3d5e7cae51920159b4e11410b8a92687623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -2 lines) Patch
M webrtc/call.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/call/call.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
sprang_webrtc
4 years, 5 months ago (2016-07-06 12:06:23 UTC) #3
sprang_webrtc
4 years, 5 months ago (2016-07-12 08:01:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdc2e3d5e7cae51920159b4e11410b8a92687623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698