TransportFeedback must be able to start with dropped packets.

TransportFeedback must be able to start with dropped packets.

A bug in the transpot feedback adapter causes new feedback message to
always start with a received packet. This makes it impossible for the
receiver to distinguish from actual dropped packets and dropped feedback
messages.

BUG=webrtc:6073
R=stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/956ed71a11296bcb7f22b66dbc9492efb921985f

[sprang_webrtc, 2016-07-05 09:10:26]

sprang@webrtc.org changed reviewers:
+ stefan@webrtc.org

[stefan-webrtc, 2016-07-05 09:20:24]

lgtm

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right):

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:137: // of the
first received packet in the feedback.
Tricky, good with a comment. :)

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc (right):

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc:75: 
Remove this empty line

[sprang_webrtc, 2016-07-05 09:44:57]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2016-07-05 09:44:57]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2122863002/#ps20001 (title:
"Nit")

[commit-bot: I haz the power, 2016-07-05 09:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sprang_webrtc, 2016-07-05 09:45:08]

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/remote_bitrate...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right):

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/remote_bitrate...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:137: // of the
first received packet in the feedback.
On 2016/07/05 09:20:23, stefan-webrtc (holmer) wrote:
> Tricky, good with a comment. :)

Acknowledged.

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc (right):

https://codereview.webrtc.org/2122863002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc:75: 
On 2016/07/05 09:20:23, stefan-webrtc (holmer) wrote:
> Remove this empty line

Done.

[commit-bot: I haz the power, 2016-07-05 10:01:13]

Description was changed from

==========
TransportFeedback must be able to start with dropped packets.

A bug in the transpot feedback adapter causes new feedback message to
always start with a received packet. This makes it impossible for the
receiver to distinguish from actual dropped packets and dropped feedback
messages.

BUG=webrtc:6073
==========

to

==========
TransportFeedback must be able to start with dropped packets.

A bug in the transpot feedback adapter causes new feedback message to
always start with a received packet. This makes it impossible for the
receiver to distinguish from actual dropped packets and dropped feedback
messages.

BUG=webrtc:6073
R=stefan@webrtc.org

Committed: https://crrev.com/956ed71a11296bcb7f22b66dbc9492efb921985f
Cr-Commit-Position: refs/heads/master@{#13381}
==========

[commit-bot: I haz the power, 2016-07-05 10:01:14]

Patchset 2 (id:??) landed as
https://crrev.com/956ed71a11296bcb7f22b66dbc9492efb921985f
Cr-Commit-Position: refs/heads/master@{#13381}

[sprang_webrtc, 2016-07-05 10:01:14]

Description was changed from

==========
TransportFeedback must be able to start with dropped packets.

A bug in the transpot feedback adapter causes new feedback message to
always start with a received packet. This makes it impossible for the
receiver to distinguish from actual dropped packets and dropped feedback
messages.

BUG=webrtc:6073
R=stefan@webrtc.org

Committed: https://crrev.com/956ed71a11296bcb7f22b66dbc9492efb921985f
Cr-Commit-Position: refs/heads/master@{#13381}
==========

to

==========
TransportFeedback must be able to start with dropped packets.

A bug in the transpot feedback adapter causes new feedback message to
always start with a received packet. This makes it impossible for the
receiver to distinguish from actual dropped packets and dropped feedback
messages.

BUG=webrtc:6073
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/956ed71a11296bcb7f22b66db...
==========

[sprang_webrtc, 2016-07-05 10:01:16]

Committed patchset #2 (id:20001) manually as
956ed71a11296bcb7f22b66dbc9492efb921985f (presubmit successful).