Android: Add initialize() function to VideoCapturer interface

Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture() function to a new initialize() function. These arguments are constant during the lifetime of the VideoCapturer, and are not changed for different startCapture() calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
R=sakal@webrtc.org

Committed: https://crrev.com/27dcacdbc137e4b49c3e75f17b5a36cdd1ad73ba
Cr-Commit-Position: refs/heads/master@{#13404}

[magjed_webrtc, 2016-07-05 13:05:40]

Description was changed from

==========
Android: Add initialize() function to VideoCapturer interface

BUG=
==========

to

==========
Android: Add initialize() function to VideoCapturer interface

BUG=
==========

[magjed_webrtc, 2016-07-05 13:05:41]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2016-07-05 14:17:35]

Patchset #6 (id:100001) has been deleted

[magjed_webrtc, 2016-07-05 14:17:40]

Patchset #5 (id:80001) has been deleted

[magjed_webrtc, 2016-07-05 14:17:53]

Patchset #4 (id:60001) has been deleted

[magjed_webrtc, 2016-07-05 14:18:00]

Patchset #3 (id:40001) has been deleted

[magjed_webrtc, 2016-07-05 14:18:05]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2016-07-05 14:18:13]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-07-05 14:24:49]

Description was changed from

==========
Android: Add initialize() function to VideoCapturer interface

BUG=
==========

to

==========
Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture()
function to a new initialize() function. These arguments are constant during the
lifetime of the VideoCapturer, and are not changed for different startCapture()
calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might
not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced
with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
==========

[magjed_webrtc, 2016-07-05 14:34:06]

Patchset #1 (id:120001) has been deleted

[magjed_webrtc, 2016-07-05 14:52:36]

Patchset #1 (id:140001) has been deleted

[magjed_webrtc, 2016-07-05 15:50:30]

Patchset #1 (id:160001) has been deleted

[magjed_webrtc, 2016-07-05 15:50:45]

sami - Please take a look.

[sakal, 2016-07-06 13:32:07]

lgtm

[magjed_webrtc, 2016-07-06 13:45:02]

The CQ bit was checked by magjed@webrtc.org

[commit-bot: I haz the power, 2016-07-06 13:45:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-06 15:45:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 15:45:45]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[magjed_webrtc, 2016-07-07 08:00:40]

Description was changed from

==========
Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture()
function to a new initialize() function. These arguments are constant during the
lifetime of the VideoCapturer, and are not changed for different startCapture()
calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might
not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced
with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
==========

to

==========
Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture()
function to a new initialize() function. These arguments are constant during the
lifetime of the VideoCapturer, and are not changed for different startCapture()
calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might
not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced
with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
R=sakal@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/27dcacdbc137e4b49c3e75f17...
==========

[magjed_webrtc, 2016-07-07 08:00:41]

Committed patchset #4 (id:240001) manually as
27dcacdbc137e4b49c3e75f17b5a36cdd1ad73ba (presubmit successful).

[commit-bot: I haz the power, 2016-07-07 08:00:43]

Description was changed from

==========
Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture()
function to a new initialize() function. These arguments are constant during the
lifetime of the VideoCapturer, and are not changed for different startCapture()
calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might
not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced
with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
R=sakal@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/27dcacdbc137e4b49c3e75f17...
==========

to

==========
Android: Add initialize() function to VideoCapturer interface

This CL moves some arguments, e.g. the camera thread, from the startCapture()
function to a new initialize() function. These arguments are constant during the
lifetime of the VideoCapturer, and are not changed for different startCapture()
calls. Setting them once allows for simplifications in the code.

This CL also fixes a bug for camera2 where pendingCameraSwitchSemaphore might
not be released when switchEventsHandler is null.

In camera1, the handler lock and 'cameraThreadHandler == null' check is replaced
with an atomic boolean to check if the camera is stopped.

BUG=webrtc:5519
R=sakal@webrtc.org

Committed: https://crrev.com/27dcacdbc137e4b49c3e75f17b5a36cdd1ad73ba
Cr-Commit-Position: refs/heads/master@{#13404}
==========