Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 2122373004: Adding more logging to BasicPortAllocator. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
honghaiz3, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding more logging to BasicPortAllocator. Logging when a candidate is gathered or the gathering state or a Port changes. This will make it easier to identify problems related to candidate gathering. Committed: https://crrev.com/a64edb8f79de5997d0f475b8e580326c069abfa2 Cr-Commit-Position: refs/heads/master@{#13490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M webrtc/p2p/client/basicportallocator.cc View 6 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Taylor Brandstetter
4 years, 5 months ago (2016-07-07 21:59:53 UTC) #2
pthatcher1
lgtm
4 years, 5 months ago (2016-07-13 23:43:30 UTC) #3
honghaiz3
lgtm
4 years, 5 months ago (2016-07-15 00:16:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2122373004/1
4 years, 5 months ago (2016-07-15 20:32:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 21:42:27 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 21:42:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a64edb8f79de5997d0f475b8e580326c069abfa2
Cr-Commit-Position: refs/heads/master@{#13490}

Powered by Google App Engine
This is Rietveld 408576698