webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h - Issue 2121993002: Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h

Issue 2121993002: Added NiceMock for MockRtcEventLog in several unittests where we don't care about the event logging. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h

index 9eb0c1a1d30e16989993b5ef46fcd89e268a27eb..bbe3eac01c5dc338d8165f9451ee027a6521051a 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h

@@ -47,7 +47,7 @@ class FullBweSender : public BweSender, public RemoteBitrateObserver {

bool has_received_ack_;

uint16_t last_acked_seq_num_;

int64_t last_log_time_ms_;

- MockRtcEventLog event_log_;

+ ::testing::NiceMock<MockRtcEventLog> event_log_;

RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(FullBweSender);

};

« webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc ('K') | « webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h ('k') | no next file » | no next file with comments »