Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2121983002: Remove frame rate and target bitrate from ProtectionBitrateCalculator::SetEncodingData (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove frame rate and target bitrate from ProtectionBitrateCalculator::SetEncodingData These arguments are not really known when calling SetEncodingData. They are still provided as argument to ProtectionBitrateCalculator::SetTargetRates though. This cl is broken out from https://codereview.webrtc.org/2060403002/ BUG=webrtc:5687 Committed: https://crrev.com/c2c24f795eba0ba2a13bbd0d75f87696bd7a484b Cr-Commit-Position: refs/heads/master@{#13429}

Patch Set 1 #

Patch Set 2 : Fix size_t problem. #

Messages

Total messages: 13 (5 generated)
perkj_webrtc
please
4 years, 5 months ago (2016-07-05 09:51:17 UTC) #2
stefan-webrtc
AFAICT this is a noop since UpdateMethod() is called in SetTargetRates. lgtm
4 years, 5 months ago (2016-07-08 12:04:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2121983002/20001
4 years, 5 months ago (2016-07-08 12:45:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-08 14:46:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2121983002/20001
4 years, 5 months ago (2016-07-11 07:52:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-11 08:47:39 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 08:47:42 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 08:47:42 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2c24f795eba0ba2a13bbd0d75f87696bd7a484b
Cr-Commit-Position: refs/heads/master@{#13429}

Powered by Google App Engine
This is Rietveld 408576698