Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2121963002:
Remove nonexistant test. (Closed)
|
Created:
4 years, 5 months ago by phoglund Modified:
4 years, 4 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemove nonexistant test.
I did some archaelogy here and found that the binary was (incorrectly?)
added here: https://codereview.webrtc.org/1903663002/. I can't find any
trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at
least that it doesn't exist now.
Removing it seems the right thing to do. However, I also see
rtc_sdk_peerconnection_objc target is folded into rtc_unittests in
webrtc_tests.gyp, but that target isn't listed in common_tests.json.
Should it be?
BUG=623500
TBR=tkchin@webrtc.org
Committed: https://crrev.com/75c88da8ddd6f8944f1de0980abc7cf1f026089e
Cr-Commit-Position: refs/heads/master@{#13392}
Patch Set 1 #
Messages
Total messages: 15 (7 generated)
phoglund@webrtc.org changed reviewers: + tkchin@webrtc.org
Description was changed from ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 ========== to ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin_webrtc ==========
Description was changed from ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin_webrtc ========== to ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin@webrtc.org ==========
TBR:ing to unbreak bot.
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin@webrtc.org ========== to ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin@webrtc.org ========== to ========== Remove nonexistant test. I did some archaelogy here and found that the binary was (incorrectly?) added here: https://codereview.webrtc.org/1903663002/. I can't find any trace that a rtc_sdk_peerconnection_objc_tests has ever existed, or at least that it doesn't exist now. Removing it seems the right thing to do. However, I also see rtc_sdk_peerconnection_objc target is folded into rtc_unittests in webrtc_tests.gyp, but that target isn't listed in common_tests.json. Should it be? BUG=623500 TBR=tkchin@webrtc.org Committed: https://crrev.com/75c88da8ddd6f8944f1de0980abc7cf1f026089e Cr-Commit-Position: refs/heads/master@{#13392} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/75c88da8ddd6f8944f1de0980abc7cf1f026089e Cr-Commit-Position: refs/heads/master@{#13392}
Message was sent while issue was closed.
kjellander@webrtc.org changed reviewers: + kjellander@webrtc.org
Message was sent while issue was closed.
Thanks for fixing this. I moved the test code into rtc_unittests in https://codereview.webrtc.org/2041743003/ but missed this part. lgtm
Message was sent while issue was closed.
On 2016/07/06 19:03:22, kjellander_webrtc OOO til Aug1 wrote: > Thanks for fixing this. I moved the test code into rtc_unittests in > https://codereview.webrtc.org/2041743003/ but missed this part. > lgtm Yes, but rtc_unittests isn't in common_tests.json! Then we should add it, right?
Message was sent while issue was closed.
On 2016/07/07 09:43:21, phoglund_OOO_sep_05 wrote: > On 2016/07/06 19:03:22, kjellander_webrtc OOO til Aug1 wrote: > > Thanks for fixing this. I moved the test code into rtc_unittests in > > https://codereview.webrtc.org/2041743003/ but missed this part. > > lgtm > > Yes, but rtc_unittests isn't in common_tests.json! Then we should add it, right? Yeah, if it passes. I'm not so sure about that since it's a pretty big suite but I'm trying it out in https://codereview.webrtc.org/2202503002/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
