Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2121553002: Adding back removed methods to MockNonlinearBeamformer. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding back removed methods to MockNonlinearBeamformer. This is temporary, until downstream dependencies are updated. TBR=aluebs@webrtc.org Committed: https://crrev.com/bb01781982c515f0100ea56d0e5cb62a52b67fcb Cr-Commit-Position: refs/heads/master@{#13374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2121553002/1
4 years, 5 months ago (2016-07-02 19:46:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-02 20:34:56 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-02 20:34:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bb01781982c515f0100ea56d0e5cb62a52b67fcb Cr-Commit-Position: refs/heads/master@{#13374}
4 years, 5 months ago (2016-07-02 20:35:04 UTC) #6
aluebs-webrtc
4 years, 5 months ago (2016-07-06 15:10:26 UTC) #7
Message was sent while issue was closed. 
LGTM
Thank you for doing this! :D
I don't know how I missed it in my original CL.

Powered by Google App Engine
This is Rietveld 408576698