Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: webrtc/modules/congestion_controller/congestion_controller.cc

Issue 2121273003: Add more logging about the bwe state and VideoSendStream state. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/congestion_controller.cc
diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc
index d42ad4acc513b702499ff5087a4cbba13712fbcf..1d3ac642acab9416c6f95098f387b4b75c3ffb56 100644
--- a/webrtc/modules/congestion_controller/congestion_controller.cc
+++ b/webrtc/modules/congestion_controller/congestion_controller.cc
@@ -277,6 +277,8 @@ int64_t CongestionController::GetPacerQueuingDelayMs() const {
}
void CongestionController::SignalNetworkState(NetworkState state) {
+ LOG(LS_INFO) << "SignalNetworkState "
+ << (state == kNetworkUp ? "Up" : "Down");
if (state == kNetworkUp) {
pacer_->Resume();
} else {
@@ -340,6 +342,10 @@ bool CongestionController::HasNetworkParametersToReportChanged(
last_reported_bitrate_bps_ != bitrate_bps ||
(bitrate_bps > 0 && (last_reported_fraction_loss_ != fraction_loss ||
last_reported_rtt_ != rtt));
+ if (changed && (last_reported_bitrate_bps_ == 0 || bitrate_bps == 0)) {
+ LOG(LS_INFO) << "Bitrate estimate state changed, BWE: " << bitrate_bps
+ << "bps.";
stefan-webrtc 2016/07/06 14:21:32 This will happen very often, right? Maybe it would
perkj_webrtc 2016/07/06 14:30:06 I don't think so. I only want to log when the rat
stefan-webrtc 2016/07/06 14:33:57 Ah, sorry, I misread.
+ }
last_reported_bitrate_bps_ = bitrate_bps;
last_reported_fraction_loss_ = fraction_loss;
last_reported_rtt_ = rtt;

Powered by Google App Engine
This is Rietveld 408576698