Add more logging about the bwe state and VideoSendStream state.

Add more logging about the bwe state and VideoSendStream state.

Committed: https://crrev.com/9b522f8d0474201f1bc9a5a3902d4fd861bce2cf
Cr-Commit-Position: refs/heads/master@{#13402}

[perkj_webrtc, 2016-07-06 09:38:38]

perkj@webrtc.org changed reviewers:
+ stefan@webrtc.org

[perkj_webrtc, 2016-07-06 09:38:39]

please?

[stefan-webrtc, 2016-07-06 14:21:32]

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/congestion_controller.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/congestion_controller.cc:347: << "bps.";
This will happen very often, right? Maybe it would be a good idea to rate limit
it?

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:904: << "OnBitrateUpdated: Encoder target
state changed, target bitrate "
"Encoder target rate changed: xxx bps" instead?

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:905: << encoder_target_rate_bps << "bps.";
Space before bps

[perkj_webrtc, 2016-07-06 14:30:06]

ptal

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/congestion_controller.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/congestion_controller.cc:347: << "bps.";
On 2016/07/06 14:21:32, stefan-webrtc (holmer) wrote:
> This will happen very often, right? Maybe it would be a good idea to rate
limit
> it?

I don't think so. I  only want to log when the rate is set to = or set to !=0
There is a periodic log in BitrateAllocator.

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:904: << "OnBitrateUpdated: Encoder target
state changed, target bitrate "
On 2016/07/06 14:21:32, stefan-webrtc (holmer) wrote:
> "Encoder target rate changed: xxx bps" instead?

Encoder state changed: target... ? This will only be written when the rate is
set to zero or first time none zero.

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:905: << encoder_target_rate_bps << "bps.";
On 2016/07/06 14:21:32, stefan-webrtc (holmer) wrote:
> Space before bps

Done.

[stefan-webrtc, 2016-07-06 14:33:58]

lgtm

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
File webrtc/modules/congestion_controller/congestion_controller.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/modules/congestion_con...
webrtc/modules/congestion_controller/congestion_controller.cc:347: << "bps.";
On 2016/07/06 14:30:06, perkj_webrtc wrote:
> On 2016/07/06 14:21:32, stefan-webrtc (holmer) wrote:
> > This will happen very often, right? Maybe it would be a good idea to rate
> limit
> > it?
> 
> I don't think so. I  only want to log when the rate is set to = or set to !=0
> There is a periodic log in BitrateAllocator.

Ah, sorry, I misread.

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2121273003/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:904: << "OnBitrateUpdated: Encoder target
state changed, target bitrate "
On 2016/07/06 14:30:06, perkj_webrtc wrote:
> On 2016/07/06 14:21:32, stefan-webrtc (holmer) wrote:
> > "Encoder target rate changed: xxx bps" instead?
> 
> Encoder state changed: target... ? This will only be written when the rate is
> set to zero or first time none zero.

Acknowledged.

[perkj_webrtc, 2016-07-06 14:35:39]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-07-06 14:35:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-06 16:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 16:36:37]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[perkj_webrtc, 2016-07-07 07:30:42]

The CQ bit was checked by perkj@webrtc.org

[commit-bot: I haz the power, 2016-07-07 07:30:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-07-07 07:36:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-07 07:36:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-07 07:36:47]

Description was changed from

==========
Add more logging about the bwe state and VideoSendStream state.
==========

to

==========
Add more logging about the bwe state and VideoSendStream state.

Committed: https://crrev.com/9b522f8d0474201f1bc9a5a3902d4fd861bce2cf
Cr-Commit-Position: refs/heads/master@{#13402}
==========

[commit-bot: I haz the power, 2016-07-07 07:36:48]

Patchset 2 (id:??) landed as
https://crrev.com/9b522f8d0474201f1bc9a5a3902d4fd861bce2cf
Cr-Commit-Position: refs/heads/master@{#13402}