Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2120733002: Make the state transition for a PortAllocatorSession in each derived class (Closed)

Created:
4 years, 5 months ago by honghaiz3
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make the state transition for a PortAllocatorSession in each derived class instead of in the base class. Putting them in the base class may potentially break subclasses if they have not called the same method in the base class. R=deadbeef@webrtc.org, pthatcher@webrtc.org Committed: https://crrev.com/d8f6fc46563995b5e7d1788e1c862fc4699dd1e3 Cr-Commit-Position: refs/heads/master@{#13372}

Patch Set 1 : . #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M webrtc/p2p/base/fakeportallocator.h View 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +8 lines, -16 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.h View 3 chunks +12 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
honghaiz3
4 years, 5 months ago (2016-07-02 00:00:22 UTC) #2
Taylor Brandstetter
lgtm
4 years, 5 months ago (2016-07-02 00:01:59 UTC) #4
pthatcher1
lgtm
4 years, 5 months ago (2016-07-02 00:03:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2120733002/20001
4 years, 5 months ago (2016-07-02 00:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2120733002/40001
4 years, 5 months ago (2016-07-02 00:08:37 UTC) #12
honghaiz3
4 years, 5 months ago (2016-07-02 00:31:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
d8f6fc46563995b5e7d1788e1c862fc4699dd1e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698