Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2120553002:
Add pruneTurnPorts to the IOS RTCConfiguration. (Closed)
DescriptionAdd pruneTurnPorts to the IOS RTCConfiguration.
BUG=
R=pthatcher@webrtc.org
TBR=tkchin@webrt.org
Committed: https://crrev.com/e2e35ca55df0d69bbe4a6df98dc7df9b3f3166db
Cr-Commit-Position: refs/heads/master@{#13368}
Patch Set 1 #Patch Set 2 : . #
Total comments: 4
Messages
Total messages: 24 (11 generated)
The CQ bit was checked by honghaiz@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
honghaiz@webrtc.org changed reviewers: + tkchin@webrtc.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= ========== to ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= TBR=tkchin@webrt.org ==========
honghaiz@webrtc.org changed reviewers: + pthatcher@webrtc.org
lgtm
The CQ bit was checked by honghaiz@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6648)
The CQ bit was checked by honghaiz@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org Link to the patchset: https://codereview.webrtc.org/2120553002/#ps20001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= TBR=tkchin@webrt.org ========== to ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= R=pthatcher@webrtc.org TBR=tkchin@webrt.org Committed: https://chromium.googlesource.com/external/webrtc/+/e2e35ca55df0d69bbe4a6df98... ==========
Message was sent while issue was closed.
Description was changed from ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= R=pthatcher@webrtc.org TBR=tkchin@webrt.org Committed: https://chromium.googlesource.com/external/webrtc/+/e2e35ca55df0d69bbe4a6df98... ========== to ========== Add pruneTurnPorts to the IOS RTCConfiguration. BUG= R=pthatcher@webrtc.org TBR=tkchin@webrt.org Committed: https://crrev.com/e2e35ca55df0d69bbe4a6df98dc7df9b3f3166db Cr-Commit-Position: refs/heads/master@{#13368} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as e2e35ca55df0d69bbe4a6df98dc7df9b3f3166db (presubmit successful).
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e2e35ca55df0d69bbe4a6df98dc7df9b3f3166db Cr-Commit-Position: refs/heads/master@{#13368}
Message was sent while issue was closed.
https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:97: @property(nonatomic, assign) bool pruneTurnPorts; BOOL shouldPruneTurnPorts Default is NO. https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:102: @property(nonatomic, assign) bool presumeWritableWhenFullyRelayed; I don't recall this property. It should also be a BOOL and prefixed with "should"
Message was sent while issue was closed.
On 2016/07/08 21:09:04, tkchin_webrtc wrote: > https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... > File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): > > https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... > webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:97: > @property(nonatomic, assign) bool pruneTurnPorts; > BOOL shouldPruneTurnPorts > > Default is NO. > > https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... > webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:102: > @property(nonatomic, assign) bool presumeWritableWhenFullyRelayed; > I don't recall this property. It should also be a BOOL and prefixed with > "should" Addressed in a separate CL.
Message was sent while issue was closed.
https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... File webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h (right): https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:97: @property(nonatomic, assign) bool pruneTurnPorts; On 2016/07/08 21:09:04, tkchin_webrtc wrote: > BOOL shouldPruneTurnPorts > > Default is NO. Fixed in a separate CL. https://codereview.webrtc.org/2120553002/diff/20001/webrtc/sdk/objc/Framework... webrtc/sdk/objc/Framework/Headers/WebRTC/RTCConfiguration.h:102: @property(nonatomic, assign) bool presumeWritableWhenFullyRelayed; On 2016/07/08 21:09:04, tkchin_webrtc wrote: > I don't recall this property. It should also be a BOOL and prefixed with > "should" I believe this is from a different CL by Taylor. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
