Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2119093003: clang-format on AudioDeviceBuffer (Closed)

Created:
4 years, 5 months ago by henrika_webrtc
Modified:
4 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

clang-format on AudioDeviceBuffer BUG=NONE R=magjed@webrtc.org Committed: https://crrev.com/0fd6801c3c2e059121d50b9293c41828bbdcc085 Cr-Commit-Position: refs/heads/master@{#13377}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -387 lines) Patch
M webrtc/modules/audio_device/audio_device_buffer.h View 1 chunk +64 lines, -72 lines 1 comment Download
M webrtc/modules/audio_device/audio_device_buffer.cc View 5 chunks +270 lines, -315 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
henrika_webrtc
No functional changes. Only format changes using clang-format. Will make some changes in this class ...
4 years, 5 months ago (2016-07-04 10:01:03 UTC) #3
henrika_webrtc
PTAL ;-)
4 years, 5 months ago (2016-07-04 10:03:41 UTC) #4
magjed_webrtc
lgtm https://codereview.webrtc.org/2119093003/diff/1/webrtc/modules/audio_device/audio_device_buffer.h File webrtc/modules/audio_device/audio_device_buffer.h (right): https://codereview.webrtc.org/2119093003/diff/1/webrtc/modules/audio_device/audio_device_buffer.h#newcode72 webrtc/modules/audio_device/audio_device_buffer.h:72: uint32_t _recSampleRate; Will you fix variable names to ...
4 years, 5 months ago (2016-07-04 10:04:25 UTC) #5
henrika_webrtc
Yes, my plan is to make this class perfect. Just have to add some urgent ...
4 years, 5 months ago (2016-07-04 10:07:29 UTC) #6
henrika_webrtc
4 years, 5 months ago (2016-07-04 11:01:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0fd6801c3c2e059121d50b9293c41828bbdcc085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698