Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2117823002:
mac: Make GetOSVersion() private to a cc file. (Closed)
Descriptionmac: Make GetOSVersion() private to a cc file.
Everything calls GetOSVersionName() instead, so no need to expose that.
Since it uses deprecated functions, this will make it easier to rewrite
it in a future change.
BUG=webrtc:6027
NOTRY=true
Committed: https://crrev.com/0cf208aa28ed3c1b7a0425c96f2fdf8ac29eb25d
Cr-Commit-Position: refs/heads/master@{#13399}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
thakis@chromium.org changed reviewers: + henrike@webrtc.org
thakis@chromium.org changed reviewers: + henrika@chromium.org - henrike@webrtc.org
henrika, ptal. Misspelled your email address the first time round :-/
Description was changed from ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=6027 ========== to ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=6027 ==========
Description was changed from ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=6027 ========== to ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 ==========
+tommi since he knows webrtc/base much better than I do Thanks for working in our code base Nico ;-) LGTM from my side
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
Description was changed from ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 ========== to ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true ========== to ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true ========== to ========== mac: Make GetOSVersion() private to a cc file. Everything calls GetOSVersionName() instead, so no need to expose that. Since it uses deprecated functions, this will make it easier to rewrite it in a future change. BUG=webrtc:6027 NOTRY=true Committed: https://crrev.com/0cf208aa28ed3c1b7a0425c96f2fdf8ac29eb25d Cr-Commit-Position: refs/heads/master@{#13399} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0cf208aa28ed3c1b7a0425c96f2fdf8ac29eb25d Cr-Commit-Position: refs/heads/master@{#13399} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
