Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2117463002: Dispose audio source correctly in AppRTC Demo on Android. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 5 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Dispose audio source correctly in AppRTC Demo on Android. Call dispose method on audio source in PeerConnectionClient dispose method. R=magjed@webrtc.org Committed: https://crrev.com/039083aedcd85b12f8fc2bb79b08b4500d29a4fb Cr-Commit-Position: refs/heads/master@{#13348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sakal
PTAL
4 years, 5 months ago (2016-06-30 13:37:28 UTC) #2
magjed_webrtc
lgtm
4 years, 5 months ago (2016-06-30 13:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117463002/1
4 years, 5 months ago (2016-06-30 13:55:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14679)
4 years, 5 months ago (2016-06-30 14:02:20 UTC) #7
sakal
4 years, 5 months ago (2016-06-30 14:57:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
039083aedcd85b12f8fc2bb79b08b4500d29a4fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698