Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2117283002: Rename apprtc lib to match GN lib rules. (Closed)

Created:
4 years, 5 months ago by phoglund
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename apprtc lib to match GN lib rules. Chromium's src/build/config/android/internal_rules.gni says java lib target names must end with _java or _javalib. Committed: https://crrev.com/9a123aa0c3c1a3b4637fe5f573cad51648c53e5d Cr-Commit-Position: refs/heads/master@{#13382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/examples/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
phoglund
Magnus, Per? This is a simple change to unblock chromium-in-webrtc rolling.
4 years, 5 months ago (2016-07-05 08:28:25 UTC) #2
magjed_webrtc
lgtm
4 years, 5 months ago (2016-07-05 08:49:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117283002/1
4 years, 5 months ago (2016-07-05 09:04:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 10:21:39 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 10:21:42 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 10:21:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a123aa0c3c1a3b4637fe5f573cad51648c53e5d
Cr-Commit-Position: refs/heads/master@{#13382}

Powered by Google App Engine
This is Rietveld 408576698