Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2117183005: Reland of https://codereview.webrtc.org/2044523002. (Closed)

Created:
4 years, 5 months ago by katrielc1
Modified:
4 years, 5 months ago
Reviewers:
phoglund, katrielc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of https://codereview.webrtc.org/2044523002. Landing these in WebRTC under a guard so they don't build in Chromium. The guard can be removed once Chromium has migrated to use the new GN targets. BUG=webrtc:6081 NOTRY=true Committed: https://crrev.com/1d4fefbbaf056492096e9e8a689550c6b7c49fe9 Cr-Commit-Position: refs/heads/master@{#13397}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -8 lines) Patch
M webrtc/test/fuzzers/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
A + webrtc/test/fuzzers/sdp_parser_fuzzer.cc View 1 chunk +10 lines, -4 lines 0 comments Download
A webrtc/test/fuzzers/stun_parser_fuzzer.cc View 1 chunk +28 lines, -0 lines 0 comments Download
A + webrtc/test/fuzzers/stun_validator_fuzzer.cc View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
katrielc1
Sorry for the million reviews, they should be simple at least (this is almost entirely ...
4 years, 5 months ago (2016-07-06 13:21:32 UTC) #3
phoglund
On the contrary, many small patches = good. lgtm
4 years, 5 months ago (2016-07-06 14:36:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2117183005/1
4 years, 5 months ago (2016-07-06 15:00:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 15:02:05 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 15:02:10 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 15:02:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d4fefbbaf056492096e9e8a689550c6b7c49fe9
Cr-Commit-Position: refs/heads/master@{#13397}

Powered by Google App Engine
This is Rietveld 408576698