Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2116003003: Implement RecordingIsInitialized in file_audio_device.cc. (Closed)

Created:
4 years, 5 months ago by noahric
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Implement RecordingIsInitialized in file_audio_device.cc. After https://codereview.webrtc.org/1827263002, audio devices are no longer (ever) initialized if they return true from RecordingIsInitialized. Since this was left as "return true;" for file_audio_device, the recording buffer was never set up correctly, and the audio buffer would assert when called (in debug) and FileAudioDevice would cause memory corruption (in release). BUG= Committed: https://crrev.com/28fdf5637f6c72cfc1d69dce6940415dead2e88b Cr-Commit-Position: refs/heads/master@{#13489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_device/dummy/file_audio_device.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
noahric
4 years, 5 months ago (2016-07-01 22:04:49 UTC) #2
henrika_webrtc
LGTM
4 years, 5 months ago (2016-07-04 07:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2116003003/1
4 years, 5 months ago (2016-07-07 19:54:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-07 21:55:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2116003003/1
4 years, 5 months ago (2016-07-07 22:58:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-08 00:59:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2116003003/1
4 years, 5 months ago (2016-07-14 22:50:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-15 00:51:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2116003003/1
4 years, 5 months ago (2016-07-15 17:02:22 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 17:03:59 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 17:04:12 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28fdf5637f6c72cfc1d69dce6940415dead2e88b
Cr-Commit-Position: refs/heads/master@{#13489}

Powered by Google App Engine
This is Rietveld 408576698