Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 2114063002: Fixing memory leak in TurnServer. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 4 months ago
Reviewers:
honghaiz3, pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing memory leak in TurnServer. If the test TURN server received two allocate requests from the same address, it was replacing the old allocation but not deleting it. Also switching to std::unique_ptr to make it less likely for this to pop up again. Committed: https://crrev.com/9794366ff0d8aa2cc4b07a130bae7d4987b232f7 Cr-Commit-Position: refs/heads/master@{#13449}

Patch Set 1 #

Patch Set 2 : Using std::tie, added unit test. #

Patch Set 3 : Using std::tie, added unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -11 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/testturnserver.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/turnserver.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/turnserver.cc View 1 6 chunks +8 lines, -9 lines 0 comments Download
A webrtc/p2p/base/turnserver_unittest.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Taylor Brandstetter
4 years, 5 months ago (2016-07-01 18:07:10 UTC) #2
honghaiz3
lgtm
4 years, 5 months ago (2016-07-01 18:43:55 UTC) #3
pthatcher1
lgtm
4 years, 5 months ago (2016-07-01 20:35:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2114063002/1
4 years, 5 months ago (2016-07-12 16:28:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 18:04:55 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 18:04:57 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 18:05:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9794366ff0d8aa2cc4b07a130bae7d4987b232f7
Cr-Commit-Position: refs/heads/master@{#13449}

Powered by Google App Engine
This is Rietveld 408576698