Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2114013002: mac: Remove unused GetQuickTimeVersion(). (Closed)

Created:
4 years, 5 months ago by Nico
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

mac: Remove unused GetQuickTimeVersion(). The function uses a deprecated function and is unused, so delete it. BUG=6027 NOTRY=true Committed: https://crrev.com/d7d3e05ca6cef3226ff0034e25b78fe699360bd5 Cr-Commit-Position: refs/heads/master@{#13400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M webrtc/base/macutils.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/macutils.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/base/macutils_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Nico
4 years, 5 months ago (2016-07-01 15:51:59 UTC) #2
Nico
henrika, ptal. Misspelled your email address the first time round :-/
4 years, 5 months ago (2016-07-06 14:36:58 UTC) #4
Nico
adding tommi to this one as well :-)
4 years, 5 months ago (2016-07-06 15:19:19 UTC) #6
tommi
lgtm
4 years, 5 months ago (2016-07-06 15:53:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2114013002/1
4 years, 5 months ago (2016-07-06 15:53:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 5 months ago (2016-07-06 17:53:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2114013002/1
4 years, 5 months ago (2016-07-06 18:00:59 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 18:03:19 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 18:03:20 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 18:03:28 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7d3e05ca6cef3226ff0034e25b78fe699360bd5
Cr-Commit-Position: refs/heads/master@{#13400}

Powered by Google App Engine
This is Rietveld 408576698