Remove unused copy of last received keyframe.

webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1081 matching lines @@
     EncodedImageCallback* callback) {
   encoded_complete_callback_ = callback;
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 VP8DecoderImpl::VP8DecoderImpl()
     : decode_complete_callback_(NULL),
       inited_(false),
       feedback_mode_(false),
       decoder_(NULL),
-      last_keyframe_(),
       image_format_(VPX_IMG_FMT_NONE),
       ref_frame_(NULL),
       propagation_cnt_(-1),
       last_frame_width_(0),
       last_frame_height_(0),
       key_frame_required_(true) {}
 
 VP8DecoderImpl::~VP8DecoderImpl() {
   inited_ = true;  // in order to do the actual release
   Release();
@@ skipping 139 matching lines @@
   if (vpx_codec_decode(decoder_, buffer, input_image._length, 0,
                        VPX_DL_REALTIME)) {
     // Reset to avoid requesting key frames too often.
     if (propagation_cnt_ > 0) {
       propagation_cnt_ = 0;
     }
     return WEBRTC_VIDEO_CODEC_ERROR;
   }
 #endif
 
-  // Store encoded frame if key frame. (Used in Copy method.)
-  if (input_image._frameType == kVideoFrameKey && input_image._buffer != NULL) {
-    const uint32_t bytes_to_copy = input_image._length;
-    if (last_keyframe_._size < bytes_to_copy) {
-      delete[] last_keyframe_._buffer;
-      last_keyframe_._buffer = NULL;
-      last_keyframe_._size = 0;
-    }
-    uint8_t* temp_buffer = last_keyframe_._buffer;  // Save buffer ptr.
-    uint32_t temp_size = last_keyframe_._size;      // Save size.
-    last_keyframe_ = input_image;                   // Shallow copy.
-    last_keyframe_._buffer = temp_buffer;           // Restore buffer ptr.
-    last_keyframe_._size = temp_size;               // Restore buffer size.
-    if (!last_keyframe_._buffer) {
-      // Allocate memory.
-      last_keyframe_._size = bytes_to_copy;
-      last_keyframe_._buffer = new uint8_t[last_keyframe_._size];
-    }
-    // Copy encoded frame.
-    memcpy(last_keyframe_._buffer, input_image._buffer, bytes_to_copy);
-    last_keyframe_._length = bytes_to_copy;
-  }
-
   img = vpx_codec_get_frame(decoder_, &iter);
   ret = ReturnFrame(img, input_image._timeStamp, input_image.ntp_time_ms_);
   if (ret != 0) {
     // Reset to avoid requesting key frames too often.
     if (ret < 0 && propagation_cnt_ > 0)
       propagation_cnt_ = 0;
     return ret;
   }
   if (feedback_mode_) {
     // Whenever we receive an incomplete key frame all reference buffers will
@@ skipping 97 matching lines @@
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 int VP8DecoderImpl::RegisterDecodeCompleteCallback(
     DecodedImageCallback* callback) {
   decode_complete_callback_ = callback;
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 int VP8DecoderImpl::Release() {
-  if (last_keyframe_._buffer != NULL) {
-    delete[] last_keyframe_._buffer;
-    last_keyframe_._buffer = NULL;
-  }
   if (decoder_ != NULL) {
     if (vpx_codec_destroy(decoder_)) {
       return WEBRTC_VIDEO_CODEC_MEMORY;
     }
     delete decoder_;
     decoder_ = NULL;
   }
   if (ref_frame_ != NULL) {
     vpx_img_free(&ref_frame_->img);
     delete ref_frame_;
@@ skipping 16 matching lines @@
     return -1;
   }
   if (vpx_codec_control(copy->decoder_, VP8_SET_REFERENCE, ref_frame_) !=
       VPX_CODEC_OK) {
     return -1;
   }
   return 0;
 }
 
 }  // namespace webrtc