Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2112963002: Add UNKNOWN_CELLULAR network type and allow unknown network type in NetworkMonitor (Closed)

Created:
4 years, 5 months ago by honghaiz3
Modified:
4 years, 5 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

This helps recognize more network types and even if the "unknown" network type is not helpful for identifying the network type, it helps bind sockets to the network. BUG= R=glaznev@webrtc.org Committed: https://crrev.com/e59122889fc6e480238613558c67de13747ae487 Cr-Commit-Position: refs/heads/master@{#13351}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M webrtc/api/java/android/org/webrtc/NetworkMonitor.java View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 3 chunks +16 lines, -8 lines 0 comments Download
M webrtc/api/java/jni/androidnetworkmonitor_jni.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/java/jni/androidnetworkmonitor_jni.cc View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
honghaiz3
4 years, 5 months ago (2016-06-30 18:29:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2112963002/20001
4 years, 5 months ago (2016-06-30 18:30:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14706)
4 years, 5 months ago (2016-06-30 18:44:03 UTC) #8
AlexG
lgtm
4 years, 5 months ago (2016-06-30 18:52:13 UTC) #9
honghaiz3
4 years, 5 months ago (2016-06-30 20:00:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
e59122889fc6e480238613558c67de13747ae487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698