Fixing flakiness of CreateDataChannelAfterNegotiate.

Fixing flakiness of CreateDataChannelAfterNegotiate.

Test worked by creating a dummy data channel just to trigger the
SDP generation, then creating two data channels after negotiation.

However the dummy data channel is then racing with the "real" data
channel to get negotiated, so they could be signaled in the reverse
of the expected order.

Fixed this by simply waiting for the dummy data channel to be
signaled before creating the other data channels.

BUG=webrtc:3980
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/bf2f569b220347c5d07d3c7d1e967bcaa0a3aad0
Cr-Commit-Position: refs/heads/master@{#13329}

[Taylor Brandstetter, 2016-06-29 16:51:21]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-06-29 16:51:42]

deadbeef@webrtc.org changed reviewers:
+ skvlad@webrtc.org

[pthatcher1, 2016-06-29 18:15:01]

lgtm

[skvlad, 2016-06-29 18:16:20]

lgtm

[commit-bot: I haz the power, 2016-06-29 18:25:19]

Description was changed from

==========
Fixing flakiness of CreateDataChannelAfterNegotiate.

Test worked by creating a dummy data channel just to trigger the
SDP generation, then creating two data channels after negotiation.

However the dummy data channel is then racing with the "real" data
channel to get negotiated, so they could be signaled in the reverse
of the expected order.

Fixed this by simply waiting for the dummy data channel to be
signaled before creating the other data channels.

BUG=webrtc:3980
==========

to

==========
Fixing flakiness of CreateDataChannelAfterNegotiate.

Test worked by creating a dummy data channel just to trigger the
SDP generation, then creating two data channels after negotiation.

However the dummy data channel is then racing with the "real" data
channel to get negotiated, so they could be signaled in the reverse
of the expected order.

Fixed this by simply waiting for the dummy data channel to be
signaled before creating the other data channels.

BUG=webrtc:3980
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed: https://crrev.com/bf2f569b220347c5d07d3c7d1e967bcaa0a3aad0
Cr-Commit-Position: refs/heads/master@{#13329}
==========

[Taylor Brandstetter, 2016-06-29 18:25:20]

Description was changed from

==========
Fixing flakiness of CreateDataChannelAfterNegotiate.

Test worked by creating a dummy data channel just to trigger the
SDP generation, then creating two data channels after negotiation.

However the dummy data channel is then racing with the "real" data
channel to get negotiated, so they could be signaled in the reverse
of the expected order.

Fixed this by simply waiting for the dummy data channel to be
signaled before creating the other data channels.

BUG=webrtc:3980
==========

to

==========
Fixing flakiness of CreateDataChannelAfterNegotiate.

Test worked by creating a dummy data channel just to trigger the
SDP generation, then creating two data channels after negotiation.

However the dummy data channel is then racing with the "real" data
channel to get negotiated, so they could be signaled in the reverse
of the expected order.

Fixed this by simply waiting for the dummy data channel to be
signaled before creating the other data channels.

BUG=webrtc:3980
R=pthatcher@webrtc.org, skvlad@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/bf2f569b220347c5d07d3c7d1...
==========

[commit-bot: I haz the power, 2016-06-29 18:25:21]

Patchset 1 (id:??) landed as
https://crrev.com/bf2f569b220347c5d07d3c7d1e967bcaa0a3aad0
Cr-Commit-Position: refs/heads/master@{#13329}

[Taylor Brandstetter, 2016-06-29 18:25:25]

Committed patchset #1 (id:1) manually as
bf2f569b220347c5d07d3c7d1e967bcaa0a3aad0 (presubmit successful).