Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2111923003: Reland of Combine webrtc/api/java/android and webrtc/api/java/src. (Closed)

Created:
4 years, 5 months ago by sakal
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Combine webrtc/api/java/android and webrtc/api/java/src. (patchset #1 id:1 of https://codereview.webrtc.org/2106333005/ ) Reason for revert: Issues fixed Original issue's description: > Revert of Combine webrtc/api/java/android and webrtc/api/java/src. (patchset #1 id:1 of https://codereview.webrtc.org/2111823002/ ) > > Reason for revert: > Breaks downstream dependencies > > Original issue's description: > > Combine webrtc/api/java/android and webrtc/api/java/src. > > > > It used to be that there was a Java api for devices not running Android > > but that is no longer the case. I combined the directories and made > > the folder structure chromium style. > > > > BUG=webrtc:6067 > > R=magjed@webrtc.org, tommi@webrtc.org > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/ceefe20dd65387d83059d9fc1ce84842650ed5e2 > > TBR=magjed@webrtc.org,tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6067 > > Committed: https://chromium.googlesource.com/external/webrtc/+/9b0dc622d46b6b09bb7ccaca6b2f68739c87ff8d TBR=magjed@webrtc.org,tommi@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6067 Committed: https://crrev.com/d34a711f224730e3602ad4e455cd876ed6061d7d Cr-Commit-Position: refs/heads/master@{#13363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -16732 lines) Patch
M webrtc/api/BUILD.gn View 3 chunks +65 lines, -65 lines 0 comments Download
A + webrtc/api/android/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/AudioSource.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/AudioTrack.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/CallSessionFileRotatingLogSink.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/Camera1Enumerator.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/Camera2Capturer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/CameraEnumerator.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/CameraVideoCapturer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/DataChannel.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/EglBase.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/EglBase10.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/EglBase14.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/GlShader.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/GlTextureFrameBuffer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/GlUtil.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/IceCandidate.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaConstraints.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaSource.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaStream.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/MediaStreamTrack.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/Metrics.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/NetworkMonitor.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/NetworkMonitorAutoDetect.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/PeerConnection.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/RendererCommon.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/RtpParameters.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/RtpReceiver.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/RtpSender.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/SdpObserver.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/SessionDescription.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/StatsObserver.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/StatsReport.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/SurfaceTextureHelper.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoCapturer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoRenderer.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoRendererGui.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoSource.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/java/src/org/webrtc/VideoTrack.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/jni/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/jni/androidmediacodeccommon.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/androidmediadecoder_jni.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/api/android/jni/androidmediadecoder_jni.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + webrtc/api/android/jni/androidmediaencoder_jni.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/api/android/jni/androidmediaencoder_jni.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + webrtc/api/android/jni/androidmetrics_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/api/android/jni/androidnetworkmonitor_jni.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/api/android/jni/androidnetworkmonitor_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + webrtc/api/android/jni/androidvideocapturer_jni.h View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/api/android/jni/androidvideocapturer_jni.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + webrtc/api/android/jni/classreferenceholder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/jni/classreferenceholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/jni_helpers.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/jni/jni_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/jni_onload.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/native_handle_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/api/android/jni/native_handle_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/peerconnection_jni.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + webrtc/api/android/jni/surfacetexturehelper_jni.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/api/android/jni/surfacetexturehelper_jni.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/androidvideocapturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/api.gyp View 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/api/api_java.gyp View 1 chunk +2 lines, -4 lines 0 comments Download
D webrtc/api/java/README View 1 chunk +0 lines, -10 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/Camera1Enumerator.java View 1 chunk +0 lines, -172 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/Camera2Capturer.java View 1 chunk +0 lines, -926 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/Camera2Enumerator.java View 1 chunk +0 lines, -208 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/CameraEnumerationAndroid.java View 1 chunk +0 lines, -237 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/CameraEnumerator.java View 1 chunk +0 lines, -20 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/CameraVideoCapturer.java View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/EglBase.java View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/EglBase10.java View 1 chunk +0 lines, -301 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/EglBase14.java View 1 chunk +0 lines, -258 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/GlRectDrawer.java View 1 chunk +0 lines, -216 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/GlShader.java View 1 chunk +0 lines, -128 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/GlTextureFrameBuffer.java View 1 chunk +0 lines, -125 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/GlUtil.java View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/NetworkMonitor.java View 1 chunk +0 lines, -252 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/NetworkMonitorAutoDetect.java View 1 chunk +0 lines, -622 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/java/android/org/webrtc/RendererCommon.java View 1 chunk +0 lines, -246 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/SurfaceTextureHelper.java View 1 chunk +0 lines, -499 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +0 lines, -565 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +0 lines, -672 lines 0 comments Download
D webrtc/api/java/android/org/webrtc/VideoRendererGui.java View 1 chunk +0 lines, -650 lines 0 comments Download
D webrtc/api/java/jni/OWNERS View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/api/java/jni/androidmediacodeccommon.h View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/api/java/jni/androidmediadecoder_jni.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/api/java/jni/androidmediadecoder_jni.cc View 1 chunk +0 lines, -995 lines 0 comments Download
D webrtc/api/java/jni/androidmediaencoder_jni.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 chunk +0 lines, -1306 lines 0 comments Download
D webrtc/api/java/jni/androidmetrics_jni.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/api/java/jni/androidnetworkmonitor_jni.h View 1 chunk +0 lines, -92 lines 0 comments Download
D webrtc/api/java/jni/androidnetworkmonitor_jni.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D webrtc/api/java/jni/androidvideocapturer_jni.h View 1 chunk +0 lines, -101 lines 0 comments Download
D webrtc/api/java/jni/androidvideocapturer_jni.cc View 1 chunk +0 lines, -348 lines 0 comments Download
D webrtc/api/java/jni/classreferenceholder.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/api/java/jni/classreferenceholder.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D webrtc/api/java/jni/jni_helpers.h View 1 chunk +0 lines, -191 lines 0 comments Download
D webrtc/api/java/jni/jni_helpers.cc View 1 chunk +0 lines, -350 lines 0 comments Download
D webrtc/api/java/jni/jni_onload.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/api/java/jni/native_handle_impl.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/api/java/jni/native_handle_impl.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -2300 lines 0 comments Download
D webrtc/api/java/jni/surfacetexturehelper_jni.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/api/java/jni/surfacetexturehelper_jni.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/AudioSource.java View 1 chunk +0 lines, -21 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/AudioTrack.java View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/CallSessionFileRotatingLogSink.java View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/DataChannel.java View 1 chunk +0 lines, -126 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/IceCandidate.java View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaCodecVideoDecoder.java View 1 chunk +0 lines, -714 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +0 lines, -650 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaConstraints.java View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaSource.java View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaStream.java View 1 chunk +0 lines, -111 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/MediaStreamTrack.java View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/Metrics.java View 1 chunk +0 lines, -77 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/PeerConnection.java View 1 chunk +0 lines, -306 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java View 1 chunk +0 lines, -293 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/RtpParameters.java View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/RtpReceiver.java View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/RtpSender.java View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/SdpObserver.java View 1 chunk +0 lines, -26 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/SessionDescription.java View 1 chunk +0 lines, -40 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/StatsObserver.java View 1 chunk +0 lines, -17 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/StatsReport.java View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/VideoCapturer.java View 1 chunk +0 lines, -113 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/VideoRenderer.java View 1 chunk +0 lines, -149 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/VideoSource.java View 1 chunk +0 lines, -46 lines 0 comments Download
D webrtc/api/java/src/org/webrtc/VideoTrack.java View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/api/test/androidtestinitializer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2111923003/1
4 years, 5 months ago (2016-07-01 10:57:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-07-01 10:57:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2111923003/1
4 years, 5 months ago (2016-07-01 12:10:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 12:10:56 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 12:11:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d34a711f224730e3602ad4e455cd876ed6061d7d
Cr-Commit-Position: refs/heads/master@{#13363}

Powered by Google App Engine
This is Rietveld 408576698