Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: webrtc/media/base/mediaengine.h

Issue 2111813002: Revert of Move RtcEventLog object from inside VoiceEngine to Call. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/rtc_event_log.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 virtual const std::vector<VideoCodec>& video_codecs() = 0; 81 virtual const std::vector<VideoCodec>& video_codecs() = 0;
82 virtual RtpCapabilities GetVideoCapabilities() = 0; 82 virtual RtpCapabilities GetVideoCapabilities() = 0;
83 83
84 // Starts AEC dump using existing file, a maximum file size in bytes can be 84 // Starts AEC dump using existing file, a maximum file size in bytes can be
85 // specified. Logging is stopped just before the size limit is exceeded. 85 // specified. Logging is stopped just before the size limit is exceeded.
86 // If max_size_bytes is set to a value <= 0, no limit will be used. 86 // If max_size_bytes is set to a value <= 0, no limit will be used.
87 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0; 87 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) = 0;
88 88
89 // Stops recording AEC dump. 89 // Stops recording AEC dump.
90 virtual void StopAecDump() = 0; 90 virtual void StopAecDump() = 0;
91
92 // Starts RtcEventLog using existing file. A maximum file size in bytes can be
93 // specified. Logging is stopped just before the size limit is exceeded.
94 // If max_size_bytes is set to a value <= 0, no limit will be used.
95 virtual bool StartRtcEventLog(rtc::PlatformFile file,
96 int64_t max_size_bytes) = 0;
97
98 // Stops recording an RtcEventLog.
99 virtual void StopRtcEventLog() = 0;
91 }; 100 };
92 101
93 102
94 #if !defined(DISABLE_MEDIA_ENGINE_FACTORY) 103 #if !defined(DISABLE_MEDIA_ENGINE_FACTORY)
95 class MediaEngineFactory { 104 class MediaEngineFactory {
96 public: 105 public:
97 typedef cricket::MediaEngineInterface* (*MediaEngineCreateFunction)(); 106 typedef cricket::MediaEngineInterface* (*MediaEngineCreateFunction)();
98 // Creates a media engine, using either the compiled system default or the 107 // Creates a media engine, using either the compiled system default or the
99 // creation function specified in SetCreateFunction, if specified. 108 // creation function specified in SetCreateFunction, if specified.
100 static MediaEngineInterface* Create(); 109 static MediaEngineInterface* Create();
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 } 168 }
160 169
161 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) { 170 virtual bool StartAecDump(rtc::PlatformFile file, int64_t max_size_bytes) {
162 return voice_.StartAecDump(file, max_size_bytes); 171 return voice_.StartAecDump(file, max_size_bytes);
163 } 172 }
164 173
165 virtual void StopAecDump() { 174 virtual void StopAecDump() {
166 voice_.StopAecDump(); 175 voice_.StopAecDump();
167 } 176 }
168 177
178 virtual bool StartRtcEventLog(rtc::PlatformFile file,
179 int64_t max_size_bytes) {
180 return voice_.StartRtcEventLog(file, max_size_bytes);
181 }
182
183 virtual void StopRtcEventLog() { voice_.StopRtcEventLog(); }
184
169 protected: 185 protected:
170 VOICE voice_; 186 VOICE voice_;
171 VIDEO video_; 187 VIDEO video_;
172 }; 188 };
173 189
174 enum DataChannelType { 190 enum DataChannelType {
175 DCT_NONE = 0, 191 DCT_NONE = 0,
176 DCT_RTP = 1, 192 DCT_RTP = 1,
177 DCT_SCTP = 2 193 DCT_SCTP = 2
178 }; 194 };
179 195
180 class DataEngineInterface { 196 class DataEngineInterface {
181 public: 197 public:
182 virtual ~DataEngineInterface() {} 198 virtual ~DataEngineInterface() {}
183 virtual DataMediaChannel* CreateChannel(DataChannelType type) = 0; 199 virtual DataMediaChannel* CreateChannel(DataChannelType type) = 0;
184 virtual const std::vector<DataCodec>& data_codecs() = 0; 200 virtual const std::vector<DataCodec>& data_codecs() = 0;
185 }; 201 };
186 202
187 webrtc::RtpParameters CreateRtpParametersWithOneEncoding(); 203 webrtc::RtpParameters CreateRtpParametersWithOneEncoding();
188 204
189 } // namespace cricket 205 } // namespace cricket
190 206
191 #endif // WEBRTC_MEDIA_BASE_MEDIAENGINE_H_ 207 #endif // WEBRTC_MEDIA_BASE_MEDIAENGINE_H_
OLDNEW
« no previous file with comments | « webrtc/call/rtc_event_log.cc ('k') | webrtc/media/engine/fakewebrtccall.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698