Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2111813002: Revert of Move RtcEventLog object from inside VoiceEngine to Call. (Closed)

Created:
4 years, 5 months ago by ivoc
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, hlundin-webrtc, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move RtcEventLog object from inside VoiceEngine to Call. (patchset #16 id:420001 of https://codereview.webrtc.org/1748403002/ ) Reason for revert: Reverting all CLs related to moving the eventlog, as they break Chromium tests. Original issue's description: > Move RtcEventLog object from inside VoiceEngine to Call. > > In addition to moving the logging object itself, this also moves the interface from PeerConnectionFactory to PeerConnection, which makes more sense for this functionality. An API parameter to set an upper limit to the size of the logfile is introduced. > The old interface on PeerConnectionFactory is not removed in this CL, because it is called from Chrome, it will be removed after Chrome is updated to use the PeerConnection interface. > > BUG=webrtc:4741, webrtc:5603, chromium:609749 > R=solenberg@webrtc.org, stefan@webrtc.org, terelius@webrtc.org, tommi@webrtc.org > > Committed: https://crrev.com/1895526c6130e3d0e9b154f95079b8eda7567016 > Cr-Commit-Position: refs/heads/master@{#13321} TBR=solenberg@webrtc.org,tommi@webrtc.org,stefan@webrtc.org,terelius@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4741, webrtc:5603, chromium:609749 Committed: https://crrev.com/9e03c3b3726e704a492a6b8ed2800dccd59c83a9 Cr-Commit-Position: refs/heads/master@{#13340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -383 lines) Patch
M webrtc/api/java/src/org/webrtc/PeerConnection.java View 2 chunks +0 lines, -23 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/PeerConnectionFactory.java View 2 chunks +28 lines, -0 lines 0 comments Download
M webrtc/api/peerconnection.h View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/api/peerconnection.cc View 3 chunks +0 lines, -22 lines 0 comments Download
M webrtc/api/peerconnectionfactory.h View 1 chunk +5 lines, -8 lines 0 comments Download
M webrtc/api/peerconnectionfactory.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/api/peerconnectionfactoryproxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 2 chunks +15 lines, -20 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/audio/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 10 chunks +6 lines, -21 lines 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 3 chunks +1 line, -4 lines 0 comments Download
M webrtc/call.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/call/call.cc View 13 chunks +18 lines, -21 lines 0 comments Download
M webrtc/call/rtc_event_log.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/call/rtc_event_log.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M webrtc/media/base/mediaengine.h View 2 chunks +16 lines, -0 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/fakewebrtccall.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.h View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 6 chunks +2 lines, -13 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 5 chunks +17 lines, -10 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 3 chunks +26 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 2 chunks +9 lines, -6 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +2 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/pc/channelmanager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/test/mock_voe_channel_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 4 chunks +4 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 8 chunks +13 lines, -93 lines 0 comments Download
M webrtc/voice_engine/channel_manager.h View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel_manager.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/voice_engine/include/voe_codec.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/codec_test.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of Move RtcEventLog object from inside VoiceEngine to Call.
4 years, 5 months ago (2016-06-30 07:59:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2111813002/1
4 years, 5 months ago (2016-06-30 07:59:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 07:59:48 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 07:59:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e03c3b3726e704a492a6b8ed2800dccd59c83a9
Cr-Commit-Position: refs/heads/master@{#13340}

Powered by Google App Engine
This is Rietveld 408576698