Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2111803002: Revert of Fix to make the start/stop functions for the Rtc Eventlog non-virtual. (Closed)

Created:
4 years, 5 months ago by ivoc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix to make the start/stop functions for the Rtc Eventlog non-virtual. (patchset #2 id:40001 of https://codereview.webrtc.org/2107253002/ ) Reason for revert: Reverting all CLs related to moving the eventlog, as they break Chromium tests. Original issue's description: > Fix to make the start/stop functions for the Rtc Eventlog non-virtual. > > This is needed to prevent the Chromium import bot from breaking. > > BUG= > R=tommi@webrtc.org > > Committed: https://crrev.com/df6ecea8ac7c4c3bddeda089d5fb9eccdf38a0a6 > Cr-Commit-Position: refs/heads/master@{#13324} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/308c7b0b5ae8da14cbe049b64a48de0e12d91125 Cr-Commit-Position: refs/heads/master@{#13339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M webrtc/api/peerconnectioninterface.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of Fix to make the start/stop functions for the Rtc Eventlog non-virtual.
4 years, 5 months ago (2016-06-30 07:57:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2111803002/1
4 years, 5 months ago (2016-06-30 07:57:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 07:57:35 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 07:57:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/308c7b0b5ae8da14cbe049b64a48de0e12d91125
Cr-Commit-Position: refs/heads/master@{#13339}

Powered by Google App Engine
This is Rietveld 408576698