Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h

Issue 2111293003: Removed callback between old AudioConferenceMixer and OutputMixer. The audio frame with mixed audio… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@new_mixer_format
Patch Set: Minor things: specialized DCHECK macros, rearranged methods in header, etc. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
diff --git a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
index 322e45229f5f99c4e551d724ddacc9739d72821a..40e3b70d2992f80040b3e107ae68c693a33f804c 100644
--- a/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
+++ b/webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
+ * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
*
* Use of this source code is governed by a BSD-style license
* that can be found in the LICENSE file in the root of the source
@@ -72,15 +72,13 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
void Process() override;
// NewAudioConferenceMixer functions
- int32_t RegisterMixedStreamCallback(
- OldAudioMixerOutputReceiver* mixReceiver) override;
- int32_t UnRegisterMixedStreamCallback() override;
int32_t SetMixabilityStatus(MixerAudioSource* participant,
bool mixable) override;
bool MixabilityStatus(const MixerAudioSource& participant) const override;
- int32_t SetMinimumMixingFrequency(Frequency freq) override;
int32_t SetAnonymousMixabilityStatus(MixerAudioSource* participant,
bool mixable) override;
+ void Mix(AudioFrame* audio_frame_for_mixing) override;
+ int32_t SetMinimumMixingFrequency(Frequency freq) override;
bool AnonymousMixabilityStatus(
const MixerAudioSource& participant) const override;
@@ -133,8 +131,10 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
MixerAudioSourceList* participantList) const;
// Mix the AudioFrames stored in audioFrameList into mixedAudio.
- int32_t MixFromList(AudioFrame* mixedAudio,
- const AudioFrameList& audioFrameList) const;
+ static int32_t MixFromList(AudioFrame* mixedAudio,
+ const AudioFrameList& audioFrameList,
+ int32_t id,
+ bool use_limiter);
// Mix the AudioFrames stored in audioFrameList into mixedAudio. No
// record will be kept of this mix (e.g. the corresponding MixerAudioSources
@@ -151,9 +151,6 @@ class NewAudioConferenceMixerImpl : public NewAudioConferenceMixer {
Frequency _minimumMixingFreq;
- // Mix result callback
- OldAudioMixerOutputReceiver* _mixReceiver;
-
// The current sample frequency and sample size when mixing.
Frequency _outputFrequency;
size_t _sampleSize;

Powered by Google App Engine
This is Rietveld 408576698