Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: webrtc/modules/audio_mixer/source/new_audio_conference_mixer_impl.h

Issue 2111293003: Removed callback between old AudioConferenceMixer and OutputMixer. The audio frame with mixed audio… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@new_mixer_format
Patch Set: Added variable name. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 ~NewAudioConferenceMixerImpl(); 65 ~NewAudioConferenceMixerImpl();
66 66
67 // Must be called after ctor. 67 // Must be called after ctor.
68 bool Init(); 68 bool Init();
69 69
70 // Module functions 70 // Module functions
71 int64_t TimeUntilNextProcess() override; 71 int64_t TimeUntilNextProcess() override;
72 void Process() override; 72 void Process() override;
73 73
74 // NewAudioConferenceMixer functions 74 // NewAudioConferenceMixer functions
75 int32_t RegisterMixedStreamCallback( 75 void Mix(AudioFrame*) override;
tommi 2016/07/06 19:42:17 add param name
aleloi 2016/07/07 09:20:16 Done.
ivoc 2016/07/07 13:46:16 Try to keep the order of the functions the same as
aleloi 2016/07/07 14:29:12 Done.
76 OldAudioMixerOutputReceiver* mixReceiver) override;
77 int32_t UnRegisterMixedStreamCallback() override;
78 int32_t SetMixabilityStatus(MixerAudioSource* participant, 76 int32_t SetMixabilityStatus(MixerAudioSource* participant,
79 bool mixable) override; 77 bool mixable) override;
80 bool MixabilityStatus(const MixerAudioSource& participant) const override; 78 bool MixabilityStatus(const MixerAudioSource& participant) const override;
81 int32_t SetMinimumMixingFrequency(Frequency freq) override; 79 int32_t SetMinimumMixingFrequency(Frequency freq) override;
82 int32_t SetAnonymousMixabilityStatus(MixerAudioSource* participant, 80 int32_t SetAnonymousMixabilityStatus(MixerAudioSource* participant,
83 bool mixable) override; 81 bool mixable) override;
84 bool AnonymousMixabilityStatus( 82 bool AnonymousMixabilityStatus(
85 const MixerAudioSource& participant) const override; 83 const MixerAudioSource& participant) const override;
86 84
87 private: 85 private:
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 142
145 bool LimitMixedAudio(AudioFrame* mixedAudio) const; 143 bool LimitMixedAudio(AudioFrame* mixedAudio) const;
146 144
147 std::unique_ptr<CriticalSectionWrapper> _crit; 145 std::unique_ptr<CriticalSectionWrapper> _crit;
148 std::unique_ptr<CriticalSectionWrapper> _cbCrit; 146 std::unique_ptr<CriticalSectionWrapper> _cbCrit;
149 147
150 int32_t _id; 148 int32_t _id;
151 149
152 Frequency _minimumMixingFreq; 150 Frequency _minimumMixingFreq;
153 151
154 // Mix result callback
155 OldAudioMixerOutputReceiver* _mixReceiver;
156
157 // The current sample frequency and sample size when mixing. 152 // The current sample frequency and sample size when mixing.
158 Frequency _outputFrequency; 153 Frequency _outputFrequency;
159 size_t _sampleSize; 154 size_t _sampleSize;
160 155
161 // Memory pool to avoid allocating/deallocating AudioFrames 156 // Memory pool to avoid allocating/deallocating AudioFrames
162 MemoryPool<AudioFrame>* _audioFramePool; 157 MemoryPool<AudioFrame>* _audioFramePool;
163 158
164 // List of all participants. Note all lists are disjunct 159 // List of all participants. Note all lists are disjunct
165 MixerAudioSourceList _participantList; // May be mixed. 160 MixerAudioSourceList _participantList; // May be mixed.
166 // Always mixed, anonomously. 161 // Always mixed, anonomously.
(...skipping 12 matching lines...) Expand all
179 // Counter keeping track of concurrent calls to process. 174 // Counter keeping track of concurrent calls to process.
180 // Note: should never be higher than 1 or lower than 0. 175 // Note: should never be higher than 1 or lower than 0.
181 int16_t _processCalls; 176 int16_t _processCalls;
182 177
183 // Used for inhibiting saturation in mixing. 178 // Used for inhibiting saturation in mixing.
184 std::unique_ptr<AudioProcessing> _limiter; 179 std::unique_ptr<AudioProcessing> _limiter;
185 }; 180 };
186 } // namespace webrtc 181 } // namespace webrtc
187 182
188 #endif // WEBRTC_MODULES_AUDIO_MIXER_SOURCE_NEW_AUDIO_CONFERENCE_MIXER_IMPL_H_ 183 #endif // WEBRTC_MODULES_AUDIO_MIXER_SOURCE_NEW_AUDIO_CONFERENCE_MIXER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698