Enabling IPv6 socket recv timestamp test, and making less flaky.

Enabling IPv6 socket recv timestamp test, and making less flaky.

The test worked by sleeping a certain time, then checking that the
difference between recv timestamps before and after the sleep was
within some margin of the requested sleep time.

However, this means that imprecision of SleepMs makes the test flaky.
This source of flakiness can be removed by comparing to the actual
time slept instead of the requested time.

Also making the margin larger, to further reduce the likelihood of
flakiness.

R=pthatcher@webrtc.org, stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/6f82535f45697fe75cbc90b8ed8756eefa82eef3

[Taylor Brandstetter, 2016-07-01 18:06:12]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org, stefan@webrtc.org

[stefan-webrtc, 2016-07-18 07:17:48]

lgtm, thanks!

[pthatcher1, 2016-08-08 22:23:18]

lgtm

[Taylor Brandstetter, 2016-08-09 16:37:32]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-09 16:37:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-09 16:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 16:49:53]

Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/17072)

[Taylor Brandstetter, 2016-08-11 21:52:49]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-08-11 21:52:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-11 22:20:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:20:02]

Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/9482)

[commit-bot: I haz the power, 2016-08-11 22:38:44]

Description was changed from

==========
Enabling IPv6 socket recv timestamp test, and making less flaky.

The test worked by sleeping a certain time, then checking that the
difference between recv timestamps before and after the sleep was
within some margin of the requested sleep time.

However, this means that imprecision of SleepMs makes the test flaky.
This source of flakiness can be removed by comparing to the actual
time slept instead of the requested time.

Also making the margin larger, to further reduce the likelihood of
flakiness.
==========

to

==========
Enabling IPv6 socket recv timestamp test, and making less flaky.

The test worked by sleeping a certain time, then checking that the
difference between recv timestamps before and after the sleep was
within some margin of the requested sleep time.

However, this means that imprecision of SleepMs makes the test flaky.
This source of flakiness can be removed by comparing to the actual
time slept instead of the requested time.

Also making the margin larger, to further reduce the likelihood of
flakiness.

R=pthatcher@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/6f82535f45697fe75cbc90b8ed8756eefa82eef3
Cr-Commit-Position: refs/heads/master@{#13733}
==========

[Taylor Brandstetter, 2016-08-11 22:38:45]

Description was changed from

==========
Enabling IPv6 socket recv timestamp test, and making less flaky.

The test worked by sleeping a certain time, then checking that the
difference between recv timestamps before and after the sleep was
within some margin of the requested sleep time.

However, this means that imprecision of SleepMs makes the test flaky.
This source of flakiness can be removed by comparing to the actual
time slept instead of the requested time.

Also making the margin larger, to further reduce the likelihood of
flakiness.
==========

to

==========
Enabling IPv6 socket recv timestamp test, and making less flaky.

The test worked by sleeping a certain time, then checking that the
difference between recv timestamps before and after the sleep was
within some margin of the requested sleep time.

However, this means that imprecision of SleepMs makes the test flaky.
This source of flakiness can be removed by comparing to the actual
time slept instead of the requested time.

Also making the margin larger, to further reduce the likelihood of
flakiness.

R=pthatcher@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/6f82535f45697fe75cbc90b8e...
==========

[commit-bot: I haz the power, 2016-08-11 22:38:45]

Patchset 1 (id:??) landed as
https://crrev.com/6f82535f45697fe75cbc90b8ed8756eefa82eef3
Cr-Commit-Position: refs/heads/master@{#13733}

[Taylor Brandstetter, 2016-08-11 22:38:46]

Committed patchset #1 (id:1) manually as
6f82535f45697fe75cbc90b8ed8756eefa82eef3 (presubmit successful).