Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2110853005: Add back P2PTransportChannel.Connect, for Chromium. (Closed)

Created:
4 years, 5 months ago by Taylor Brandstetter
Modified:
4 years, 5 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add back P2PTransportChannel.Connect, for Chromium. Will remove it as soon as Chromium does a roll and can stop using it. TBR=pthatcher@webrtc.org NOTRY=True Committed: https://crrev.com/886815bc36ee0b8b559a29ee1d08f0ab50622917 Cr-Commit-Position: refs/heads/master@{#13332}

Patch Set 1 #

Patch Set 2 : Add back P2PTransportChannel.Connect, for Chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2110853005/20001
4 years, 5 months ago (2016-06-29 22:19:29 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 22:21:09 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:21:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/886815bc36ee0b8b559a29ee1d08f0ab50622917
Cr-Commit-Position: refs/heads/master@{#13332}

Powered by Google App Engine
This is Rietveld 408576698