Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: webrtc/api/java/jni/peerconnection_jni.cc

Issue 2110853003: Separate the JNI function that controls logging levels into two. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Separated the tracing/logging enabled flags Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/base/java/src/org/webrtc/Logging.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/jni/peerconnection_jni.cc
diff --git a/webrtc/api/java/jni/peerconnection_jni.cc b/webrtc/api/java/jni/peerconnection_jni.cc
index a5ba254c32461222cd9d5e35508943c16dbee40d..db89001a1f726e4b9257e5cf7ecd1044675d3dee 100644
--- a/webrtc/api/java/jni/peerconnection_jni.cc
+++ b/webrtc/api/java/jni/peerconnection_jni.cc
@@ -884,8 +884,7 @@ JOW(void, DataChannel_dispose)(JNIEnv* jni, jobject j_dc) {
}
JOW(void, Logging_nativeEnableTracing)(
- JNIEnv* jni, jclass, jstring j_path, jint nativeLevels,
- jint nativeSeverity) {
+ JNIEnv* jni, jclass, jstring j_path, jint nativeLevels) {
std::string path = JavaToStdString(jni, j_path);
if (nativeLevels != webrtc::kTraceNone) {
webrtc::Trace::set_level_filter(nativeLevels);
@@ -898,7 +897,11 @@ JOW(void, Logging_nativeEnableTracing)(
static LogcatTraceContext* g_trace_callback = new LogcatTraceContext();
}
}
- if (nativeSeverity >= rtc::LS_SENSITIVE && nativeSeverity <= rtc::LS_ERROR) {
+}
+
+JOW(void, Logging_nativeEnableLogToDebugOutput)
+ (JNIEnv *jni, jclass, jint nativeSeverity) {
+ if (nativeSeverity >= rtc::LS_SENSITIVE && nativeSeverity <= rtc::LS_NONE) {
rtc::LogMessage::LogToDebug(
static_cast<rtc::LoggingSeverity>(nativeSeverity));
}
« no previous file with comments | « no previous file | webrtc/base/java/src/org/webrtc/Logging.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698