Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2110663004: Remove unused constructor from VCMPacket. (Closed)

Created:
4 years, 5 months ago by johan
Modified:
4 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused constructor from VCMPacket. BUG= R=pbos@webrtc.org, sprang@webrtc.org Committed: https://crrev.com/37f93af0323fe28688192bc9e3c889903466f37d Cr-Commit-Position: refs/heads/master@{#13325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M webrtc/modules/video_coding/jitter_buffer_unittest.cc View 4 chunks +21 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/packet.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/packet.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
johan
4 years, 5 months ago (2016-06-29 11:45:35 UTC) #2
sprang_webrtc
lgtm
4 years, 5 months ago (2016-06-29 13:53:10 UTC) #3
pbos-webrtc
lgtm
4 years, 5 months ago (2016-06-29 15:26:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2110663004/1
4 years, 5 months ago (2016-06-29 15:32:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/14619)
4 years, 5 months ago (2016-06-29 15:44:10 UTC) #8
johan
Committed patchset #1 (id:1) manually as 37f93af0323fe28688192bc9e3c889903466f37d (presubmit successful).
4 years, 5 months ago (2016-06-29 16:03:27 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 16:03:28 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/37f93af0323fe28688192bc9e3c889903466f37d
Cr-Commit-Position: refs/heads/master@{#13325}

Powered by Google App Engine
This is Rietveld 408576698