Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2110503002: Revert "Pull out the PostFilter to its own NonlinearBeamformer API" (Closed)

Created:
4 years, 5 months ago by aluebs-webrtc
Modified:
4 years, 5 months ago
Reviewers:
aluebs-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert "Pull out the PostFilter to its own NonlinearBeamformer API" This reverts commit b983112bc7686ed4276def4c9215c498444c6bdd. It was breaking dependencies. TBR=aluebs@webrtc.org BUG= Committed: https://crrev.com/a3c51ea9f49872b9317e45c089b77f8187738dca Cr-Commit-Position: refs/heads/master@{#13316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -177 lines) Patch
M webrtc/common_audio/lapped_transform.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 6 chunks +7 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/audio_processing/beamformer/beamformer.h View 1 chunk +48 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/mock_nonlinear_beamformer.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.h View 5 chunks +17 lines, -43 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer.cc View 8 chunks +59 lines, -73 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_test.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/beamformer/nonlinear_beamformer_unittest.cc View 17 chunks +29 lines, -29 lines 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
aluebs-webrtc
4 years, 5 months ago (2016-06-28 17:38:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3c51ea9f49872b9317e45c089b77f8187738dca.

Powered by Google App Engine
This is Rietveld 408576698