Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2110373002: Revert of Fix for RtcEventLog ObjC interface (Closed)

Created:
4 years, 5 months ago by ivoc
Modified:
4 years, 5 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix for RtcEventLog ObjC interface (patchset #3 id:40001 of https://codereview.webrtc.org/2106103003/ ) Reason for revert: Reverting all CLs related to moving the eventlog, as they break Chromium tests. Original issue's description: > Fix for RtcEventLog ObjC interface > > This moves the RtcEventLog start/stop functions to PeerConnection on the objC interface. > > BUG= > R=tkchin@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/c43bf56ef1e3f91bbbf936ed4aca6916bb4f081c TBR=tkchin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/bf02e2070f48257f5d81b20594d7a7fe92e753be Cr-Commit-Position: refs/heads/master@{#13338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -44 lines) Patch
M webrtc/examples/objc/AppRTCDemo/ARDAppClient.m View 3 chunks +12 lines, -13 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm View 2 chunks +0 lines, -26 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 3 chunks +29 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnection.h View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ivoc
Created Revert of Fix for RtcEventLog ObjC interface
4 years, 5 months ago (2016-06-30 07:54:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2110373002/1
4 years, 5 months ago (2016-06-30 07:54:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 07:55:06 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 07:55:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf02e2070f48257f5d81b20594d7a7fe92e753be
Cr-Commit-Position: refs/heads/master@{#13338}

Powered by Google App Engine
This is Rietveld 408576698